[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] gnu: Add evilwm.
From: |
Eric Bavier |
Subject: |
Re: [PATCH 2/2] gnu: Add evilwm. |
Date: |
Tue, 20 Oct 2015 14:37:22 -0500 |
User-agent: |
Roundcube Webmail/1.0.6 |
On 2015-10-20 02:56, address@hidden wrote:
Eric Bavier <address@hidden> skribis:
On Fri, 16 Oct 2015 10:37:43 +0200
address@hidden (Ludovic Courtès) wrote:
[...]
+ 'install 'install-fonts-dir
+ ;; The X font server will not add directories to
the font
+ ;; path unless they contain a "fonts.dir" file, so
add some
+ ;; dummy files.
+ (lambda* (#:key outputs #:allow-other-keys)
+ (let ((out (assoc-ref outputs "out")))
+ (for-each (lambda (d)
+ (call-with-output-file
+ (string-append out
"/share/fonts/X11"
+ "/" d
"/fonts.dir")
+ (lambda (p)
+ (format p "0~%"))))
+ '("75dpi" "100dpi" "misc"
"cyrillic"))
So how did you settle on "0~%"? :-)
I ran 'mkfontdir' on an empty directory, and the "fonts.dir" file it
wrote
contained just a "0" on a line of its own. I'm not sure whether things
would
work with just an empty file.
From 45c524710742550013a8513b641e8d488806f7c9 Mon Sep 17 00:00:00 2001
From: Eric Bavier <address@hidden>
Date: Thu, 15 Oct 2015 17:34:26 -0500
Subject: [PATCH 4/4] gnu: Add evilwm.
* gnu/packages/wm.scm (evilwm): New variable.
[...]
+ (arguments
+ `(#:modules ((srfi srfi-26)
+ ,@%gnu-build-system-modules)
Note that %GNU-BUILD-SYSTEM-MODULES is the set of modules *imported* in
the build environment (inputs of the derivation), not the set of
modules
visible in the build script. See ‘%default-modules’
vs. ‘%gnu-build-system-modules’ in (guix build-system gnu) for the
difference.
Thanks for the pointer. I saw some other packages using
%gnu-build-system-modules
and wasn't aware of the subtleties.
So it should rather be:
#:modules ((srfi srfi-26)
(guix build utils)
(guix build gnu-build-system))
I'll use that then.
In practice it probably won’t make any difference.
I don't mind being pedantic. :)
Otherwise LGTM.
Great! Thanks for the reviews. I'll push with those changes.
--
`~Eric
Re: [PATCH 1/2] gnu: Add xlsfonts., Ludovic Courtès, 2015/10/16