Re: [PATCH] gnu: Add ghc-clock.

[Paul van der Walt]

Hi Eric,

On 2015-10-22 at 05:25, quoth address@hidden:
>> +(define-public ghc-clock
>> +  (package
>> +    (name "ghc-clock")
>> +    (version "0.5.1")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (string-append
>> +             "http://hackage.haskell.org/package/";
>> +             "clock/"
>> +             "clock-" version ".tar.gz"))
>> +       (sha256
>> +        (base32 "1ncph7vi2q6ywwc8ysxl1ibw6i5dwfvln88ssfazk8jgpj4iyykw"))))
>> +    (build-system haskell-build-system)
>> +    (arguments `(#:tests? #f)) ;; Testing suite depends on ghc-clock
>
> A trick that's used with some other packages is to define an unexported
> *-bootstrap package.  The ghc-clock-bootstrap package would have tests
> disabled, then the ghc-clock package would inherit from the
> ghc-clock-bootstrap package, declare ghc-clock-bootstrap as an input, and
> enable tests.

I see what you mean, that's a nice idea.  I've reshuffled the order of
the patches around what used to be ghc-clock a bit, turned it into
ghc-clock-bootstrap, and when the needed test packages (which were the
ones depending on ghc-clock) are defined, i add ghc-clock with tests.
This works!  Could you please tell me if i've done it properly?
Everything (including your other comments) has been pushed to the
`wip-haskell-platform-7.10.2-a` branch.

Thank you again for so much constructive criticism, i hope the patches
are finally up to scratch!

Regards,
p.