Re: [PATCH] Fix subread on non-x86_64

[Ludovic Courtès]

Ricardo Wurmus <address@hidden> skribis:

> the attached patch should fix the build of subread on non-x86_64 by
> overriding the CC and CCFLAGS variables, which by default are set to
> contain a lot of x86_64 optimisations.

Nice!  Could you add a comment explaining that?

> From 71a37b56d0962f0db4009bdb6a88c22025278a00 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Fri, 23 Oct 2015 14:16:27 +0200
> Subject: [PATCH] gnu: subread: Use SSE optimizations on x86_64 only.
>
> * gnu/packages/bioinformatics.scm (subread)[arguments]: Override CC and
>   CCFLAGS conditionally dependent on target system.

[...]

> +               (if (string-prefix? "x86_64" system)
> +                   (string-append "CCFLAGS=" (string-join (append flags 
> flags64) " "))
> +                   (string-append "CCFLAGS=" (string-join flags " "))))

The last argument to ‘string-join’ can be omitted here.

OK with these two changes.

It may be a good case for ‘guix challenge’ here: If things like
-mtune=native or FDO creep in, ‘guix challenge’ is likely to flag them.

Thanks,
Ludo’.