[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] refresh: Support comma separated updater types.
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH] refresh: Support comma separated updater types. |
Date: |
Tue, 27 Oct 2015 21:18:21 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Alex Kost <address@hidden> skribis:
> From 4a5132f171dfe6bac99661e75e7c5e53c4f74116 Mon Sep 17 00:00:00 2001
> From: Alex Kost <address@hidden>
> Date: Tue, 27 Oct 2015 21:13:05 +0300
> Subject: [PATCH] refresh: Support comma separated updater types.
>
> * guix/scripts/refresh.scm (%options): Handle comma separated types for
> '--type' option.
> (guix-refresh): Adjust accordingly.
> (show-help): Likewise.
> * doc/guix.texi (Invoking guix refresh): Document it.
[...]
> + (let ((names (map string->symbol (string-split arg #\,))))
I prefer ‘string-tokenize’, which is standard, even though it’s more
verbose.
> + (lists
> + (apply append lists))))
Rather: (concatenate lists).
OK with these changes.
Thank you for the quick patch!
Ludo’.