Re: [PATCH 06/10] gnu: Add python-swiftclient.

[Ricardo Wurmus]

> From 9207e8e3ae7cc78e6377cd811ce30454fce42081 Mon Sep 17 00:00:00 2001
> From: Efraim Flashner <address@hidden>
> Date: Mon, 23 Nov 2015 20:27:37 +0200
> Subject: [PATCH 06/10] gnu: Add python-swiftclient.

> * gnu/packages/openstack.scm (python-swiftclient, python2-swiftclient):
> New variables.
> ---
>  gnu/packages/openstack.scm | 53 
> ++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 53 insertions(+)

> diff --git a/gnu/packages/openstack.scm b/gnu/packages/openstack.scm
> index 43f957b..d0f65f0 100644
> --- a/gnu/packages/openstack.scm
> +++ b/gnu/packages/openstack.scm
> @@ -750,3 +750,56 @@ LDAP.")
>           ,@(alist-delete
>              "python-oauthlib"
>              (package-native-inputs keystoneclient)))))))
> +
> +(define-public python-swiftclient
> +  (package
> +    (name "python-swiftclient")
> +    (version "2.6.0")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (pypi-uri "python-swiftclient" version))
> +        (sha256
> +          (base32
> +           "1j33l4z9vqh0scfncl4fxg01zr1hgqxhhai6gvcih1gccqm4nd7p"))))

The alignment of “(base32” is too far to the right, I think.  (Are you
using Emacs to automatically align expressions?)

> +  (build-system python-build-system)
> +  (native-inputs
> +   `(("python-pbr", python-pbr)
> +     ("python-setuptools" ,python-setuptools)
> +     ;; some packages are needed for the tests
> +     ("python-coverage" ,python-coverage)
> +     ("python-discover" ,python-discover)
> +     ("python-hacking" ,python-hacking)
> +     ("python-mock" ,python-mock)
> +     ("python-oslosphinx" ,python-oslosphinx)
> +     ("python-keystoneclient" ,python-keystoneclient)
> +     ("python-sphinx" ,python-sphinx)

Sphix is probably for generating documentation, so I’d move this above
the comment because it could be misunderstood.

> +     ("python-testrepository" ,python-testrepository)
> +     ("python-testtools" ,python-testtools)))
> +  (propagated-inputs
> +   `(("python-requests" ,python-requests)
> +     ("python-six" ,python-six)))
> +  (home-page "http://www.openstack.org/";)
> +  (synopsis "OpenStack Object Storage API Client Library")
> +  (description
> +   "OpenStack Object Storage (code-named Swift) creates redundant, scalable
> +object storage using clusters of standardized servers to store petabytes of
> +accessible data.  It is not a file system or real-time data storage system, 
> but
> +rather a long-term storage system for a more permanent type of static data 
> that
> +can be retrieved, leveraged, and then updated if necessary.  Primary 
> examples of
> +data that best fit this type of storage model are virtual machine images, 
> photo
> +storage, email storage and backup archiving. Having no central \"brain\" or
                                               ^___ two spaces, please :)
                                               
> +master point of control provides greater scalability, redundancy and 
> permanence.")

(Is it just me or are these lines really just a bit little longer than
usual?)

> +  (license asl2.0)))
> +
> +(define-public python2-swiftclient
> +  (let ((swiftclient (package-with-python2 python-swiftclient)))
> +    (package (inherit swiftclient)
> +      (propagated-inputs
> +       `(("python2-futures" ,python2-futures)
> +         ,@(package-inputs swiftclient)))

I think this should be “package-propagated-inputs” instead of
“package-inputs”.

> +      (native-inputs
> +       `(("python2-keystoneclient" ,python2-keystoneclient)
> +         ,@(alist-delete
> +            "python-keystoneclient"
> +            (package-native-inputs swiftclient)))))))
> -- 
> 2.6.2

Otherwise okay.

~~ Ricardo