[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/3] support: Rename user-dmddir to %user-shepherd-dir.
From: |
Mathieu Lirzin |
Subject: |
Re: [PATCH 3/3] support: Rename user-dmddir to %user-shepherd-dir. |
Date: |
Sun, 17 Jan 2016 21:49:55 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
address@hidden (Ludovic Courtès) writes:
> Mathieu Lirzin <address@hidden> skribis:
>
>> * modules/shepherd/support.scm (user-dmddir): Rename to ...
>> (%user-shepherd-dir): ... this. Honor XDG variables and use
>> '~/.config/shepherd' as default value. All consumers changed.
>> (mkdir-p): New procedure. Export it.
>> (default-config-file): Use it.
>> (verify-dir): Likewise.
>
> Cool!
>
>> +(define %user-shepherd-dir
>> + ;; sheperd default directory if shepherd is run as a normal user.
> ^^^
> Typo. :-)
>
> I would rename the variable to ‘%user-config-dir’ or similar; I think
> it’s putting the package name everywhere just makes it more difficult to
> rename it. :-)
Done.
>> + (string-append (or (getenv "XDG_CONFIG_HOME")
>> + (string-append user-homedir "/.config"))
> ^^^
> No tabs please!
OK.
> Could you update shepherd.texi to so that it mentions the right
> location, make sure XDG_CACHE_HOME is unset in AM_TESTS_ENVIRONMENT (or
> similar), also add a test in basic.sh?
Partially done. I have only handle XDG_CONFIG_HOME to replace
'$HOME/.dmd.d'. IMO it would be better to handle other XDG variables in
future patches. WDYT?
Thanks.
--
Mathieu Lirzin
0001-support-Rename-user-dmddir-to-user-config-dir.patch
Description: Text Data