[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: powwow (possibly only manpages / (arguments) question)
From: |
Ricardo Wurmus |
Subject: |
Re: powwow (possibly only manpages / (arguments) question) |
Date: |
Wed, 2 Mar 2016 10:22:30 +0100 |
Nils Gillmann <address@hidden> writes:
> However, weird enough, during compilation on guix (second output)
> I encounter an interactive part.
I’d just patch out the line that’s responsible for “Press ENTER to
continue...”.
> I guess the real question is, does the guix definition look
> alright in (arguments)? description and synop. will be changed.
[...]
> (define-public powwow
> (package
> (name "powwow")
> (version "1.2.5")
That’s not the latest version. Seems that 1.2.14 is the latest. 1.2.5
was released in 2003, 1.2.14 was released in 2010.
> (source (origin
> (method url-fetch)
> (uri (string-append "http://lavachat.symlynx.com/unix/powwow-"
> version ".tar.gz"))
> (file-name (string-append name "-" version ".tar.gz"))
> (sha256
> (base32
> "1yxhql9m6403gddpnqm9z5nnd5q4khq74h1wdxlhhdpxzp2cdfid"))))
> (build-system gnu-build-system)
> (arguments
> `(#:make-flags
> '("CC=gcc" "CDEFS=-DUSE_REGEXP" "LDFLAGS=-lncurses")
> #:tests? #f
You should state why tests are disabled. Are they broken? Or do they
simply not exist?
> #:phases
> (modify-phases %standard-phases
> (delete 'configure)
> ;;(delete 'build)
> ;;(delete 'check)
Remove these commented lines
> (replace
> 'install
Pull the “'install” onto the same line as “(replace”.
> (lambda* (#:key outputs inputs #:allow-other-keys)
> (let* ((out (assoc-ref outputs "out"))
> (bin (string-append out "/bin"))
> (doc (string-append out "/share/doc/powwow")))
> ;;(doc (string-append (assoc-ref outputs "doc")
> ;;"/share/doc/lispf4"))
Also remove the commented stuff.
> (install-file "catrw" bin)
> (install-file "powwow" bin)
> (install-file "movie" bin)
> (install-file "movie2ascii" bin)
> (install-file "movie_play" bin)
How about
(for-each (cut install-file <> bin)
'("catrw" "powwow" "movie" "movie2ascii" "movie_play"))
> (install-file "README" doc)
> (install-file "README.follow" doc)
> (install-file "README.term" doc)
> (install-file "powwow.doc" doc)
> (install-file "powwow.help" doc)
> (install-file "Compile.how" doc)
> (install-file "Config.demo" doc)
> (install-file "COPYING" doc)
> (install-file "Changelog" doc)
> (install-file "powwow.6" doc))
Likewise:
(for-each (cut install-file <> doc)
'("README"
"README.follow"
"README.term"
...))
You may need to (use-modules (srfi srfi-26)), which provides the
immensely useful “cut”.
> #t)))))
> (home-page "http://lavachat.symlynx.com/unix/")
> (synopsis "POWWOW is a MUD client and enhanced telnet client")
> (description
> "POWWOW is a MUD client which can be used as an enhanced telnet client.
> Additional configs can be found at http://lavachat.symlynx.com/unix/")
> (license license:gpl2)))
I don’t think the license is correct. Some files are placed under
public domain (e.g. “catrw.c” or “movie_play.c”), yet others are placed
under GPLv2+ (e.g. “cmd.c”). You should probably do something like
this:
;; The following files are in the public domain:
;; catrw.c, movie_play.c, ...
(license (list license:gpl2+ license:public-domain))
~~ Ricardo