[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: simple-scan: Update to 3.19.91.
From: |
Leo Famulari |
Subject: |
Re: [PATCH] gnu: simple-scan: Update to 3.19.91. |
Date: |
Tue, 8 Mar 2016 19:05:06 -0500 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Wed, Mar 09, 2016 at 12:43:52AM +0100, Tobias Geerinckx-Rice wrote:
> Hullo Leo,
>
> On 09/03/2016, Leo Famulari <address@hidden> wrote:
> > Except where necessary for the new version to work, it's best to do
> > updates in a separate commit from other changes.
> >
> > I can apply the update myself if you say it's okay to do on its own, or
> > feel free to submit a revised patch set.
>
> Er, no. This whole thing is pretty — what's the eufemism — atomic:
>
> PackageKit support is a ‘new’ upstream addition. Guix doesn't ship a
> PackageKit expression. Nor would writing one add much value, since its
> sole purpose is to serve as an abstraction layer for other, ‘impure’
> package managers[1].
>
> I therefore simply disabled it.
I think that lots of software in our distribution has unused features or
portability "goop" that doesn't apply to us, but we don't delete that
code.
>
> > Does 'src/ui.c' cause problems for us? I'd rather not make changes to
> > upstream code except when necesssary [0], at least not without
> > discussing it with upstream first.
>
> However, a stale file (src/ui.c) in the tarball still references packagekit:
>
> make[1]: Entering directory
> '/tmp/guix-build-simple-scan-3.19.91.drv-0/build/src'
> CC simple_scan-ui.o
> ../../simple-scan-3.19.91/src/ui.c:28:41: fatal error: \
> packagekit-glib2/packagekit.h: No such file or directory
> #include "packagekit-glib2/packagekit.h"
>
> Simply adding ‘make clean’ doesn't work (because that assumes we're
> building in the source directory and Guix doesn't). Removing the
> offending file fixes the build & seemed more clear.
So, it fails to build from source if you don't delete this file?
I still don't understand why we should delete the source file.
After searching online for "packagekit simple scan" I found the Nix
package definition for Simple Scan 3.19.91. They pass to ./configure
'--disable-packagekit'. Would that work?
https://github.com/NixOS/nixpkgs/blob/master/pkgs/applications/graphics/simple-scan/default.nix
- [PATCH] gnu: simple-scan: Update to 3.19.91., Tobias Geerinckx-Rice, 2016/03/08
- Re: [PATCH] gnu: simple-scan: Update to 3.19.91., Leo Famulari, 2016/03/08
- Re: [PATCH] gnu: simple-scan: Update to 3.19.91., Tobias Geerinckx-Rice, 2016/03/08
- Re: [PATCH] gnu: simple-scan: Update to 3.19.91., Tobias Geerinckx-Rice, 2016/03/08
- Re: [PATCH] gnu: simple-scan: Update to 3.19.91.,
Leo Famulari <=
- Re: [PATCH] gnu: simple-scan: Update to 3.19.91., Tobias Geerinckx-Rice, 2016/03/08
- Re: [PATCH] gnu: simple-scan: Update to 3.19.91., Leo Famulari, 2016/03/08
- Re: [PATCH] gnu: simple-scan: Update to 3.19.91., Leo Famulari, 2016/03/09
- Re: [PATCH] gnu: simple-scan: Update to 3.19.91., Ludovic Courtès, 2016/03/09
- Re: [PATCH] gnu: simple-scan: Update to 3.19.91., Leo Famulari, 2016/03/09
- Re: [PATCH] gnu: simple-scan: Update to 3.19.91., Danny Milosavljevic, 2016/03/12
- Re: [PATCH] gnu: simple-scan: Update to 3.19.91., Danny Milosavljevic, 2016/03/13
- Re: [PATCH] gnu: simple-scan: Update to 3.19.91., Tobias Geerinckx-Rice, 2016/03/13