[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] gnu: Add freealut.
From: |
Ricardo Wurmus |
Subject: |
Re: [PATCH 1/2] gnu: Add freealut. |
Date: |
Mon, 21 Mar 2016 22:24:26 +0100 |
User-agent: |
mu4e 0.9.13; emacs 24.5.1 |
David Hashe <address@hidden> writes:
>> I see that Arch and Fedora both use the tarball from here:
>>
>>
>> http://pkgs.fedoraproject.org/repo/pkgs/freealut/freealut-1.1.0.tar.gz/e089b28a0267faabdb6c079ee173664a/freealut-1.1.0.tar.gz
>>
>> The advantage of that tarball is that it doesn’t require bootstrapping,
>> so you can do without the additional “autogen” phase and without the
>> three native inputs.
>>
>
> Done. By the way, where exactly do you find what tarball Arch and Fedora
> use for a given package? I couldn't seem to find that information on a
> cursory glance.
I looked at the PKGBUILD of the Arch package.
>> Does Freealut itself have a home page? It doesn’t seem right to me to
>> declare the website of OpenAL as the home page, when the package is
>> really just one implemenatation of the standard published on the OpenAL
>> website.
>>
>>
> I agree, but it doesn't seem to have a separate home page. Debian simply
> lists the home page as "http://www.openal.org/", for instance. I could set
> the field to #f, but guix lint complains about that and it looks like only
> the bootstrap-binaries actually do that. For now, I've added a comment
> clarifying the situation.
That’s good, thanks.
The patch looks pretty good to me now, except maybe for this
+ (uri
+ (let ((name-version-tar
+ (string-append name "-" version ".tar.gz")))
+ (string-append
+ "http://pkgs.fedoraproject.org/repo/pkgs/" name "/"
+ name-version-tar "/"
+ "e089b28a0267faabdb6c079ee173664a/"
+ name-version-tar)))
I find the let binding a bit too ... much :) But if nobody else has a
problem with this, I wouldn’t complain.
Thanks!
~~ Ricardo