[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add MilkyTracker to Guix
From: |
Alex Kost |
Subject: |
Re: [PATCH] Add MilkyTracker to Guix |
Date: |
Mon, 28 Mar 2016 13:46:06 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Kei Yamashita (2016-03-28 06:09 +0300) wrote:
> On Sun, 27 Mar 2016 10:23:37 +0300
> Efraim Flashner <address@hidden> wrote:
>> On Fri, Mar 25, 2016 at 07:54:40PM -0400, address@hidden wrote:
[...]
>> > + (arguments
>> > + '(#:configure-flags `("--without-alsa" "--without-jack")))
>>
>> In addition to Nil's comments, I was wondering about the configure
>> flags. Wouldn't it make sense to have either alsa or jack as an input?
>
> Milkytracker works fine without it on my machine. I feel like it's a
> matter of allowing the user options or sticking to the minimal build.
In my understanding (I may be wrong) our policy is to provide
full-featured software, so the features shouldn't be disabled without a
reason. Sometimes we add minimal packages (e.g., "bash-minimal",
"cups-minimal") if they are needed, but this is not such a case.
So I think you should remove these --without-… flags. And thanks for
contributing!
--
Alex
- [PATCH] Add MilkyTracker to Guix, kei, 2016/03/26
- Re: [PATCH] Add MilkyTracker to Guix, Nils Gillmann, 2016/03/26
- Re: [PATCH] Add MilkyTracker to Guix, Efraim Flashner, 2016/03/27
- Re: [PATCH] Add MilkyTracker to Guix, Kei Yamashita, 2016/03/28
- Re: [PATCH] Add MilkyTracker to Guix,
Alex Kost <=
- Re: [PATCH] Add MilkyTracker to Guix, Ricardo Wurmus, 2016/03/28
- Re: [PATCH] Add MilkyTracker to Guix, Kei Yamashita, 2016/03/28
- Re: [PATCH] Add MilkyTracker to Guix, Kei Yamashita, 2016/03/28
- Re: [PATCH] Add MilkyTracker to Guix, Kei Yamashita, 2016/03/28
- Re: [PATCH] Add MilkyTracker to Guix, Kei Yamashita, 2016/03/28
- Re: [PATCH] Add MilkyTracker to Guix, Alex Kost, 2016/03/29
- Re: [PATCH] Add MilkyTracker to Guix, Kei Yamashita, 2016/03/29
- Re: [PATCH] Add MilkyTracker to Guix, Leo Famulari, 2016/03/29
- Re: [PATCH] Add MilkyTracker to Guix, Alex Kost, 2016/03/30
Re: [PATCH] Add MilkyTracker to Guix, Nils Gillmann, 2016/03/27