[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: Add gnome-sudoku and qqwing
From: |
Leo Famulari |
Subject: |
Re: [PATCH] gnu: Add gnome-sudoku and qqwing |
Date: |
Mon, 11 Apr 2016 00:44:08 -0400 |
User-agent: |
Mutt/1.5.24 (2015-08-30) |
On Sun, Apr 10, 2016 at 11:23:51PM -0400, address@hidden wrote:
> I'm attempting something new with this patch. I want to add gnome-sudoku to
> the tree, and it requires qqwing as a dependency. QQwing didn't seem to fit
> in any other category so I put it in it's own file.
>
> Guidance would be appreciated! Thank you in advance.
Thanks for trying something new :)
I think they both would fit in games.scm. Can you put them there in a
revised patch series?
> * gnu/packages/qqwing.scm (qqwing): New variable.
> * gnu/packages/gnome.scm (gnome-sudoku): New variable.
We like to add packages as separate commits. Can you separate them in
the revised patch series?
Also, remember to add a copyright line for yourself at the top of the
file.
> +(define-public gnome-sudoku
Okay with the changes requested above.
> +(define-public qqwing
[...]
> + (uri (string-append
> + "mirror://debian/pool/main/q/qqwing/"
> + name "_" version ".orig.tar.gz"))
Why download the source code from Debian instead of https://qqwing.com
(which redirects to GitHub)?
> + (synopsis "Software for working with sudoku puzzles.")
Can you capitalize Sudoku here? Also be sure to run `guix lint` on these
packages; the linter should complain about the period in the synopsis.
> + (description
> + "QQwing is software for generating and solving Sudoku puzzles.")
Sometimes there isn't much to say. But can you try to add a little more
here? You could look for inspiration in the man page.