Re: [PATCH] gnu: i3status: Update to 2.10.

[Al McElrath]

Sorry I missed the changelog entry.

I actually can't test the %speed element because it only works with
wired connections (I'm on wireless right now). The man page just says it
should show the link speed. I don't think it's a big deal because the
man page is rather clear about how to make it work, and maybe it's not
something we want to assign by default anyway. i3status definitely
doesn't need setuid.

Thanks for reviewing and fixing up the patch!


Leo Famulari <address@hidden> writes:

> On Fri, May 06, 2016 at 02:01:08PM -0400, Leo Famulari wrote:
>> On Mon, May 02, 2016 at 04:07:19PM -0700, Al McElrath wrote:
>> > 
>> > Attached is a patch to update i3status to 2.10.
>> 
>> Thanks, it works! The changed library dependencies seem to be
>> working for me. Applied as 766a22fb4d1, preceded by a switch to https
>> URLs (I had to rebase your patch to adopt the changed home-page link
>> text).
>
> Oops, I didn't notice that the patch lacked a changelog entry, and
> committed without it. We will both have to be more careful in the
> future!
>
> It should have been like this:
>
> * gnu/packages/wm.scm (i3status): Update to 2.10.
>
>> 
>> > The Makefile runs "setcap cap_net_admin=ep
>> > $(DESTDIR)$(PREFIX)/bin/i3status)", which wasn't working in the prior
>> > version, either. It makes the "%speed" element of the "ethernet" module
>> > functional. I'm not sure how to handle that one. The package is
>> > otherwise functional.
>> 
>> I'm not sure what counts as "functional". For me, it shows the link
>> speed: 1000 Mbits. Should it dynamically show the bandwidth usage?
>> 
>> In any case, I tried making it a setuid binary, but that didn't seem to
>> create a change, and it's probably a bad idea anyways, since they only
>> ask for the cap_net_admin. Is i3status designed to be setuid?
>> 
>> I don't know how to set just this capability in Guix.
>> 
>> Advice appreciated!
>