Re: [PATCH] gnu: Add libytnef.

[Eric Bavier]

On Tue, 10 May 2016 22:14:27 -0400
Kei Yamashita <address@hidden> wrote:

> * gnu/packages/mail.scm (libytnef): New variable.
> ---
>  gnu/packages/mail.scm | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
> index 2d95753..a8e8716 100644
> --- a/gnu/packages/mail.scm
> +++ b/gnu/packages/mail.scm
> @@ -1232,3 +1232,25 @@ the 64 bit Outlook 2003 pst files.  Utilities are 
> supplied to convert email
>  messages to both mbox and MH mailbox formats.  Contacts can be converted to a
>  simple list, to vcard format, or to ldif format for import to an LDAP 
> server.")
>      (license gpl2+)))
> +
> +(define-public libytnef
> +  (package
> +    (name "libytnef")
> +    (version "1.5")

The latest git source at https://github.com/Yeraze/ytnef has fixes for
several bugs, segfaults, and memory leaks.  The configure.ac there notes
version 1.7, but I don't see any release tarballs.  Could you maybe
pester the maintainer to make a release?

> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "mirror://sourceforge/ytnef/"
> +                                  name "/" version "/" name
> +                                  "-" version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "0bkmw5sypwbyrawbb66pkc7d6crck529bs0p36j42z045vja28hv"))))
> +    (build-system gnu-build-system)
> +    (home-page "https://github.com/Yeraze/ytnef";)
> +    (synopsis "Decodes TNEF streams")

How about "Mail stream decoder" instead?  See section "Synopses and
Descriptions" in the manual.

> +    (description
> +     "ytnef is a program to decode TNEF streams (winmail.dat).  Unlike other
> +similar programs, it can also decode meeting requests and create VCal entries
> +for easy import.  It can also create vCard entries from contact cards and 
> vTodo
> +entries from task entries.")
> +    (license gpl2)))

This should be gpl2+, since the source headers contain the "or later"
verbiage.

Otherwise LGTM.  Could you send an updated patch?
`~Eric