[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add googletest
From: |
Leo Famulari |
Subject: |
Re: [PATCH] Add googletest |
Date: |
Tue, 31 May 2016 17:44:00 -0400 |
User-agent: |
Mutt/1.6.0 (2016-04-01) |
On Tue, May 31, 2016 at 08:53:17AM -0500, Lukas Gradl wrote:
> * gnu/packages/check.scm (googletest): New variable.
Awesome, thanks for this patch!
> + (build-system cmake-build-system)
I noticed in the README.md that upstream suggests use of GNU Make unless
building from a Git checkout. Did you try that?
> + (native-inputs
> + `(("python-2" ,python-2)))
The README also suggests that this is only necessary for building from
Git, although it's worth finding out what they mean by "re-generating
certain source files from templates". We prefer to re-build "generated"
source files since they are not really "source files" in many cases.
> + (replace 'install
> + (lambda _
> + (let ((out (assoc-ref %outputs "out")))
> + (and
> + (mkdir-p (string-append out "/lib"))
> + (mkdir-p (string-append out "/include"))
> + (zero?
> + (system* "cp" "-r"
> + "../googletest-release-1.7.0/include"
> + out))
> + (zero? (system* "cp" "libgtest.a" "libgtest_main.a"
> + (string-append out "/lib"))))))))))
I think these uses of (system*) could be replaced by (copy-recursively)
and (install-file), respectively.