[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 01/10] gnu: Add emacs-smex.
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH 01/10] gnu: Add emacs-smex. |
Date: |
Fri, 03 Jun 2016 10:14:23 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
"Thompson, David" <address@hidden> skribis:
> On Thu, Jun 2, 2016 at 5:26 AM, Alex Kost <address@hidden> wrote:
>> David Thompson (2016-06-01 17:05 +0300) wrote:
>>
>>> From: David Thompson <address@hidden>
>>>
>>> * gnu/packages/emacs.scm (emacs-smex): New variable.
>>> ---
>>> gnu/packages/emacs.scm | 22 ++++++++++++++++++++++
>>> 1 file changed, 22 insertions(+)
>>>
>>>
>>> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
>>> index b7c0a1f..71f2f8b 100644
>>> --- a/gnu/packages/emacs.scm
>>> +++ b/gnu/packages/emacs.scm
>>> @@ -10,6 +10,7 @@
>>> ;;; Copyright © 2015, 2016 Christopher Allan Webber <address@hidden>
>>> ;;; Copyright © 2016 humanitiesNerd <address@hidden>
>>> ;;; Copyright © 2016 Efraim Flashner <address@hidden>
>>> +;;; Copyright © 2016 David Thompson <address@hidden>
>>> ;;;
>>> ;;; This file is part of GNU Guix.
>>> ;;;
>>> @@ -1795,3 +1796,24 @@ work on lists, strings and vectors.")
>>> Emacs default configuration in uncontroversial ways that nearly everyone
>>> can
>>> agree upon.")
>>> (license license:gpl3+)))
>>> +
>>> +(define-public emacs-smex
>>> + (package
>>> + (name "emacs-smex")
>>> + (version "3.0")
>>> + (source (origin
>>> + (method url-fetch)
>>> + (uri (string-append "https://raw.githubusercontent.com"
>>> + "/nonsequitur/smex/" version "/smex.el"))
>>
>> Hm, I see in some packages you use these "githubusercontent" URLs
>> instead of <https://github.com/nonsequitur/smex/archive/3.0.tar.gz> as
>> we usually do for github. IIUC you did it to avoid extra files
>> (".gitignore", etc.) in the final package directory, right? If so, I
>> think it is not needed, I would still use a link to a tagged source code
>> archive. Moreover I think it's a problem of emacs-build-system that
>> these uninteresting files are not removed.
>>
>> Overall, I don't mind against "githubusercontent", I was just wondering.
>> Actually, I think you found a good way how to pick the needed files to
>> make several packages from a single repo (as you did for
>> "ido-ubiquitous" and "ido-completing-read+").
>
> Yes, I did this to avoid all sorts of unnecessary files making into
> the store, as well as making it more closely mimic the single elisp
> files that were released on MELPA or whatever. These URLs are stable,
> so I thought it had a good clever/useful hack ratio. :)
I think the downside is that the GitHub updater won’t be able to
identify these, although I’m not 100% sure of that.
Anyway, since the URLs are stable, it’s OK.
Thanks,
Ludo’.
- Re: [PATCH 09/10] gnu: Add emacs-yaml-mode., (continued)
- [PATCH 07/10] gnu: Add emacs-ido-completing-read+., David Thompson, 2016/06/01
- [PATCH 04/10] gnu: Add emacs-projectile., David Thompson, 2016/06/01
- [PATCH 05/10] gnu: Add emacs-elfeed., David Thompson, 2016/06/01
- [PATCH 02/10] gnu: Add emacs-js2-mode., David Thompson, 2016/06/01
- [PATCH 10/10] gnu: Add emacs-web-mode., David Thompson, 2016/06/01
- [PATCH 08/10] gnu: Add emacs-ido-ubiquitous., David Thompson, 2016/06/01
- [PATCH 06/10] gnu: Add emacs-rainbow-delimiters., David Thompson, 2016/06/01
- Re: [PATCH 01/10] gnu: Add emacs-smex., Alex Kost, 2016/06/02
Re: [PATCH 01/10] gnu: Add emacs-smex., Ludovic Courtès, 2016/06/03