[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: Add fontconfig-path-max.
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH] gnu: Add fontconfig-path-max. |
Date: |
Tue, 05 Jul 2016 10:51:23 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Hi,
address@hidden skribis:
> The code has changed in the current version, I used the version 2.12.0
> of the package to update the patch.
>
> how i know if the program will crash at run time?.
You could build it on GNU/Linux, using:
./pre-inst-env guix build fontconfig -K
Hopefully Fontconfig’s test suite would trigger the crash, but manual
testing might be needed too.
> From 21f812c2f496bdb7c39e297f66e09ea35968ddfb Mon Sep 17 00:00:00 2001
> From: Rene Saavedra <address@hidden>
> Date: Mon, 4 Jul 2016 19:34:48 -0500
> Subject: [PATCH] gnu: Add fontconfig.
Please see
<https://www.gnu.org/software/guix/manual/html_node/Submitting-Patches.html>
regarding commit logs. :-)
[...]
> +--- a/src/fcstat.c
> ++++ b/src/fcstat.c
> +@@ -278,7 +278,8 @@ FcDirChecksum (const FcChar8 *dir, time_t *checksum)
> + {
> + #endif
> + struct stat statb;
> +- char f[PATH_MAX + 1];
> ++ int size = 128;
> ++ char *f = malloc (size);
This is not OK, in part because it introduces a memory leak. The fix
should be along the same lines as the rest of the patch.
Could you check whether Debian has a patch for a more recent version of
Fontconfig?
Thanks,
Ludo’.