Re: [PATCH] gnu: linux-pam: Update to 1.3.0.

[Ludovic Courtès]

David Craven <address@hidden> skribis:

> * gnu/packages/linux.scm (linux-pam): Update it.

Cool!  This would be for core-updates.

[...]

> -     `(("flex" ,flex)
> -
> -       ;; TODO: optional dependencies
> -       ;; ("libxcrypt" ,libxcrypt)
> -       ;; ("cracklib" ,cracklib)
> -       ))
> +     `(("cracklib" ,cracklib)
> +       ("flex" ,flex)))

I think this part should indeed be a separate patch.  Also, Flex should
be ‘native-inputs’ presumably, whereas Cracklib should be in ‘inputs’.

> @@ -406,7 +402,7 @@ It has been modified to remove all non-free binary 
> blobs.")
>                                                (assoc-ref %outputs "out")
>                                                "/include/security"))
>  
> -       ;; XXX: Tests won't run in chroot, presumably because /etc/pam.d
> +       ;; FIXME: Tests won't run in chroot, presumably because /etc/pam.d
>         ;; isn't available.
>         #:tests? #f))

“XXX” is fine here, because it may be impossible for us to fix it.

Thanks!

Ludo’.