[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/2] Fix IBus input methods.
From: |
Ricardo Wurmus |
Subject: |
Re: [PATCH 0/2] Fix IBus input methods. |
Date: |
Fri, 2 Sep 2016 16:19:24 +0200 |
User-agent: |
mu4e 0.9.16; emacs 24.5.1 |
Ludovic Courtès <address@hidden> writes:
> Ricardo Wurmus <address@hidden> skribis:
>
>> 宋文武 <address@hidden> writes:
>>
>>> Ricardo Wurmus <address@hidden> writes:
>>>
>>>> gnu: gtk+-2: Add patch to support GUIX_GTK2_IM_MODULE_FILE.
>>>> gnu: gtk+: Add patch to support GUIX_GTK3_IM_MODULE_FILE.
>>>
>>> Look good to me!
>>
>> Thanks!
>>
>> What do you think: should this be a separate branch (e.g. “gtk-rebuild”)
>> or should it be pushed to “core-updates”?
>
> As discussed on IRC, I’ve added a “jobset”:
>
> https://hydra.gnu.org/jobset/gnu/gtk-im-modules
>
> There seems to be only 1 new failure compared to ‘master’:
>
> https://hydra.gnu.org/eval/109124?compare=master#tabs-now-fail
>
> Could you take a look?
This looks unrelated to me. The error is that
“tests/autojump_utils_test.py” cannot be opened in the “check” phase.
That’s expected because the file is actually called
“tests/unit/autojump_utils_test.py” (note the “unit” directory).
I’m convinced my patch to the GTKs couldn’t possibly have caused this.
Here are the relevant parts of the log:
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
starting phase `unpack'
[...]
autojump-release-v22.3.4/tests/unit/
autojump-release-v22.3.4/tests/unit/__init__.py
autojump-release-v22.3.4/tests/unit/autojump_match_test.py
autojump-release-v22.3.4/tests/unit/autojump_utils_test.py
[...]
phase `unpack' succeeded after 0.1 seconds
[...]
starting phase `patch-source-shebangs'
[...]
patch-shebang: ./tests/unit/autojump_utils_test.py: changing `/usr/bin/env
python' to
`/gnu/store/wa1yc835mb7pmmrj45xfgviqr5fbasqq-python-wrapper-3.4.3/bin/python'
patch-shebang: ./uninstall.py: changing `/usr/bin/env python' to
`/gnu/store/wa1yc835mb7pmmrj45xfgviqr5fbasqq-python-wrapper-3.4.3/bin/python'
phase `patch-source-shebangs' succeeded after 0.1 seconds
starting phase `patch-generated-file-shebangs'
phase `patch-generated-file-shebangs' succeeded after 0.0 seconds
starting phase `check'
python: can't open file 'tests/autojump_utils_test.py': [Errno 2] No such file
or directory
phase `check' failed after 1.8 seconds
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> We’ll have to merge ‘master’ into it and evaluate it again.
Can “gtk-im-modules” not be merged into the master branch directly?
~~ Ricardo