Re: [PATCH] gnu: Add libicns

[Brendan Tildesley]

On 2016-09-04 04:59, Marius Bakke wrote:
> Brendan Tildesley <address@hidden> writes:
>
>> On 2016-09-03 22:38, Marius Bakke wrote:
>>> Marius Bakke <address@hidden> writes:
>>>
>>>> Additionally this package bundles "m4" even if it doesn't use it. Can
>>>> you remove it with a "origin" snippet? See e.g. "xcb-util-xrm" for how
>>>> that's done.
>>> My mistake, it does appear to use those files, and it's not actually m4.
>>> I think using the generated libtool is probably OK.
>>>
>>> Alternatively it can be re-generated by adding a phase that invokes
>>> "autoreconf -vif". I'm not actually sure if this is desired, so just
>>> leave it for now.
>>>
>>> Thank you,
>>> Marius
>> Ah, well that lost me a bit of time.
> Sorry about that! Now it re-generates libtool and friends, so it doesn't
> hurt, at least. I only have a couple of remarks, and then someone with
> commit access can take a final glance.
>
>> From b04ad5e40ac5befe30832ffbcf3b4283b4ae1d63 Mon Sep 17 00:00:00 2001
>> From: Brendan Tildesley <address@hidden>
>> Date: Sat, 3 Sep 2016 05:53:56 +1000
>> Subject: [PATCH] gnu: Add libicns.
>>
>> * gnu/packages/image.scm (libicns): New variable.
>> ---
>>  gnu/packages/image.scm | 40 ++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 40 insertions(+)
>>
>> diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm
>> index 4fdc4ae..1b21306 100644
>> --- a/gnu/packages/image.scm
>> +++ b/gnu/packages/image.scm
>> @@ -48,6 +48,7 @@
>>    #:use-module (guix download)
>>    #:use-module (guix build-system gnu)
>>    #:use-module (guix build-system cmake)
>> +  #:use-module (guix utils)
> I don't think this is required.
>
>>    #:use-module (srfi srfi-1))
>>  
>>  (define-public libpng
>> @@ -147,6 +148,45 @@ maximum quality factor.")
>>     (license license:gpl2+)
>>     (home-page "http://www.kokkonen.net/tjko/projects.html#jpegoptim";)))
>>  
>> +(define-public libicns
>> +  (package
>> +    (name "libicns")
>> +    (version "0.8.1")
>> +    (source (origin
>> +             (method url-fetch)
>> +             (uri (string-append
>> +                   "mirror://sourceforge/icns/libicns-" version ".tar.gz"))
>> +             (sha256 (base32
>> +                      
>> "1hjm8lwap7bjyyxsyi94fh5817xzqhk4kb5y0b7mb6675xw10prk"))))
>> +    (build-system gnu-build-system)
>> +    (inputs
>> +     `(("libpng" ,libpng-1.2)
> It built fine with the latest libpng, is there a specific reason to use
> this version?
>
I just notice the configure script wasn't looking for any newer version.
I was using icns2png to
extract png file, but probably wasn't utilising libpng to do this? as
you can see it is built without
support for larger icons, but I never used that feature. This is old
software that hasn't been
updated since 2012. Perhaps it could be made to work but I wouldn't know
myself. Depends on the
standards of Guix developers.

checking libpng/png.h usability... no
checking libpng/png.h presence... no
checking for libpng/png.h... no
checking libpng10/png.h usability... no
checking libpng10/png.h presence... no
checking for libpng10/png.h... no
checking libpng12/png.h usability... yes
checking libpng12/png.h presence... yes
checking for libpng12/png.h... yes
checking for jas_init in -ljasper... no
checking for opj_setup_decoder in -lopenjpeg2... no
checking for opj_setup_decoder in -lopenjpeg... no
configure: WARNING: libopenjpeg or libjasper jp2000 codec libraries not
found
configure: WARNING: libicns will be built without 256x256 and 512x512
support

>
> The rest of the patch looks good to me.
>
> Thanks again!
> Marius

Thanks. If I posted a fix, I'd just end up making some new mistakes, so
I'll just leave it to be added!