Re: Linux kernel

[Ludovic Courtès]

David Craven <address@hidden> skribis:

> I reworked the patches for the linux-libre package and made some other
> improvements that make customizing the linux-libre package easier. I
> tested that everything builds and that there wasn't any breakage on
> x86_64, but testing the arm kernel on real hardware is a wip. Is it
> easier if I push a branch? They're 17 small patches.
>
> 86fb6ee gnu: Add linux-libre-beagle-bone-black.
> 70d7e6d gnu: Add linux-libre-multi-v7.
> 8073e6e gnu: make-linux-libre: Add supported-systems option.
> 6be1f44 gnu: linux-libre: Use kmod.
> dd9be2e gnu: make-linux-libre: Add zImage to output.
> c4772da gnu: linux-libre: Add extra-version option.
> 089b957 gnu: linux-libre: Add make-linux-libre-source.
> 5508f0d gnu: Add u-boot-beagle-bone-black.
> db2fc94 gnu: dtc: Remove patch-paths phase.
> 01c8d0a gnu: linux-libre: Add additional-configuration to make-linux-libre.
> 9ccf388 gnu: linux-libre: Use make-linux-libre.
> 86126ae gnu: linux-libre: Add support for cross-compilation.
> 2ef150b gnu: linux-libre: Move kernel configuration to configure phase.
> 4737e87 gnu: linux-libre: Apply %boot-logo patch in origin.
> c55b169 gnu: linux-libre: Use system->architecture.
> c456362 gnu: linux-libre: Use modify-phases.
> 95fe35a gnu: module-init-tools: Prevent line wrapping.

Seems we already discussed some of these, no?

Anyway, I’m fine with you sending the remaining patches with ‘git
send-email’; it makes it easier to comment on the code for me.

> The interesting parts are shown here:
>
> (define* (make-linux-libre version source supported-systems
>                            #:key
>                            (extra-version #f)
>                            (configuration-file #f)
>                            (defconfig "defconfig")
>                            (additional-configuration
>                             %default-additional-kernel-configuration))
>   (package
>     (name (if extra-version
>               (string-append "linux-libre-" extra-version)
>               "linux-libre"))
>
>
> (define-public linux-libre
>   (let* ((version "4.7.2")
>          (hash "1rp09y2hv0hvdybm2n2im9717kzxmklpgzs8k1bmdfzqxyg8cb85")
                 ^

Nitpick: Use ‘base32’ here, rather than in the callee (that way, base32
parsing happens at compile time and errors are detected early.)

Ludo’.