[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: Add git-review.
From: |
Clément Lassieur |
Subject: |
Re: [PATCH] gnu: Add git-review. |
Date: |
Sat, 10 Sep 2016 23:25:40 +0200 |
User-agent: |
mu4e 0.9.16; emacs 24.5.1 |
Efraim Flashner <address@hidden> writes:
>> It looks like ssh isn't hardcoded within git either. Is it worth doing
>> this for git-review then?
>
> This looks like you are using ssh for talking to the remote server, in
> which case it would exist outside of git-review. Or did I misunderstand
> it?
This error was a git error, when it tries to fetch a remote through ssh
in a container. It is kind of the same thing that happens with
git-review. Except that git-review is unusable without ssh. That's why
ssh has to be an input of git-review.
> It does seem that wrapping the program would be easier than trying to
> fing regexes that work to patching only certain instances of other
> programs.
I sent a patch that does the wrapping.
- Re: [PATCH] gnu: Add git-review., (continued)
- Re: [PATCH] gnu: Add git-review., Efraim Flashner, 2016/09/08
- Re: [PATCH] gnu: Add git-review., Clément Lassieur, 2016/09/09
- Re: [PATCH] gnu: Add git-review., Efraim Flashner, 2016/09/09
- Re: [PATCH] gnu: Add git-review., Clément Lassieur, 2016/09/09
- Re: [PATCH] gnu: Add git-review., Efraim Flashner, 2016/09/10
- [PATCH] gnu: python-git-review: Wrap it so 'git', 'ssh' and 'scp' are found., Clément Lassieur, 2016/09/10
- Re: [PATCH] gnu: python-git-review: Wrap it so 'git', 'ssh' and 'scp' are found., Efraim Flashner, 2016/09/11
- Re: [PATCH] gnu: Add git-review.,
Clément Lassieur <=
- Re: [PATCH] gnu: Add git-review., Alex Kost, 2016/09/09