Re: [PATCH 1/2] gnu: add python-django.

[Ludovic Courtès]

Hi,

Hartmut Goebel <address@hidden> skribis:

>> I finally reviewed this patch and pushed it as
>> d18197af7844151e38322605b11e0c75b18b55bf with small changes: adjust the
>> list of ‘native-inputs’, use ‘propagated-inputs’ for all the run-time
>> dependencies, use two semicolons for line comments (as opposed to margin
>> comments), and add the patch to gnu/local.mk.
>
> Thanks :-)
>
> Unfortunately most of the inputs are now mixed now - but maybe I'm wrong
> here, since I still did not get when to use propagated-inputs and normal
> inputs for Python packages. [*]

Sorry for messing up!

>  1.
>
>     setuptools is a run-time dependence, so it needs to be a
>     propagated-input (I assume). This is why there is a comment "Django
>     uses 'pkg_resources' (part of setuptools) to locate templates at
>     run-time.

Ooh, OK, I misinterpreted that.

>  2.
>
>     All packages below the line "Taken from tests/requirements/py3.txt."
>     are required for tests only. So I assume they are normal inputs.

That would mean that Django has no run-time dependency other than
setuptools?  I would think pillow, pyyaml, sqlparse, etc. are run-time
dependencies no?

I tested current master with:

  guix environment -C --ad-hoc python-django python -- python2

and then:

  import django

That should detect if we forgot to propagate some of the dependencies,
but of course it does not detect if we propagate too many dependencies.

>  3. Same for python2-django: enum34 and mock are used for testing only.

OK.

Do you want to send a patch to fix this?

Thanks,
Ludo’.