[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: Add mcelog.
From: |
Tobias Geerinckx-Rice |
Subject: |
Re: [PATCH] gnu: Add mcelog. |
Date: |
Wed, 14 Sep 2016 17:03:43 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 |
Marius,
On 14/09/16 15:45, Marius Bakke wrote:
> It's not visible in the cgit interface, but it actually seems to
> support normal snapshot downloads:
> https://git.kernel.org/cgit/utils/cpu/mce/mcelog.git/snapshot/v141.tar.gz
I did not know that. Thanks for the tip! It still requires a snippet,
unfortunately.
> Tobias Geerinckx-Rice <address@hidden> writes:
>> + #:tests? #f)) ; tests must be run as
>> root
> Does all tests have to run as root?
Yes. Each test wants to load modules & inject synthetic MCE events. The
daemon will even fail to start on an unsupported CPU like my current AMD
laptop.
> Also, could you reverse the order of the arguments to match other
> package definitions?
Hm: *some* other. I rather keep them in approximate order of use.
Unrelated: I see the ‘arguments‘ indentation went funky. Will fix.
>> + (home-page "http://mcelog.org/")
> Nit-pick: the trailing slash is unnecessary :)
Oh, I know, I just have a thing for proper root paths in URIs.
I'm seeing someone about that.
>> + (synopsis "Machine check monitor for x86 Linux systems")
> If this is x86-only, perhaps we should set (supported-systems)?
Indeed. Thanks!
Kind regards,
T G-R
signature.asc
Description: OpenPGP digital signature
Re: [PATCH] gnu: Add mcelog., Ludovic Courtès, 2016/09/14