[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/3] gnu: Add newlib-nano-arm-none-eabi.
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH 3/3] gnu: Add newlib-nano-arm-none-eabi. |
Date: |
Wed, 21 Sep 2016 17:40:33 +0900 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Ricardo Wurmus <address@hidden> skribis:
> * gnu/packages/embedded.scm (newlib-nano-arm-none-eabi): New variable.
[...]
> +(define-public newlib-nano-arm-none-eabi
> + (package (inherit newlib-arm-none-eabi)
> + (name "newlib-nano")
I think it should be “newlib-minimal”, no? Or does “nano” have a
special meaning?
Also, make sure to add a synopsis that mentions its minimalness, and
maybe a comment stating what the intended use case is, or how the
feature set was chosen.
Otherwise LGTM, thanks!
Ludo’.
- [PATCH 0/3] Add GCC cross compiler for arm-none-eabi., Ricardo Wurmus, 2016/09/18
- [PATCH 1/3] gnu: Add arm-none-eabi cross compiler., Ricardo Wurmus, 2016/09/18
- [PATCH 2/3] gnu: Add newlib-arm-none-eabi., Ricardo Wurmus, 2016/09/18
- [PATCH 3/3] gnu: Add newlib-nano-arm-none-eabi., Ricardo Wurmus, 2016/09/18
- Re: [PATCH 3/3] gnu: Add newlib-nano-arm-none-eabi.,
Ludovic Courtès <=
- [PATCH v2 0/4] Add GCC cross compiler for arm-none-eabi., Theodoros Foradis, 2016/09/20
- [PATCH v2 3/4] gnu: Add newlib-arm-none-eabi., Theodoros Foradis, 2016/09/20
- [PATCH v2 1/4] gnu: Add arm-none-eabi cross compiler., Theodoros Foradis, 2016/09/20
- [PATCH v2 4/4] gnu: Add arm-none-eabi-toolchain., Theodoros Foradis, 2016/09/20
- [PATCH v2 2/4] gnu: Add arm-none-eabi-gcc-6 and patches., Theodoros Foradis, 2016/09/20
- Re: [PATCH v2 0/4] Add GCC cross compiler for arm-none-eabi., Ludovic Courtès, 2016/09/27
- [PATCH v2 0/1] Add GCC cross compiler for arm-none-eabi., Theodoros Foradis, 2016/09/20