[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] gnu: perl: Enable threading support.
From: |
Ben Woodcroft |
Subject: |
Re: [PATCH 2/2] gnu: perl: Enable threading support. |
Date: |
Mon, 26 Sep 2016 20:03:56 +1000 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 |
On 24/09/16 15:05, Ludovic Courtès wrote:
Ben Woodcroft <address@hidden> skribis:
* gnu/packages/perl.scm (perl)[arguments]: Enable threading support.
* gnu/packages/commencement.scm (perl-boot0): Do not inherit 'configure'
phase from perl.
[...]
"-Uinstallusrbinperl"
"-Dinstallstyle=lib/perl5"
"-Duseshrplib"
+ "-Dusethreads"
Is -Dusethreads really needed? I thought the default behavior was to
build pthread support if ./Configure detects it. That would greatly
simplify things.
Afraid so. On master:
$ ./pre-inst-env guix environment -C --ad-hoc perl -- perl -e 'use threads'
This Perl not built to support threads
Compilation failed in require at -e line 1.
BEGIN failed--compilation aborted at -e line 1.
If not, a variant of what Eric suggests would be to honor
#:configure-flags in this phase, such that all you need is to provide
different #:configure-flags in perl-boot0.
I like this approach as it is it more general. Attached a 2-in-1 patch
to implement it.
HTH!
Indeed, good idea thanks.
ben
perl-threading20160925.patch
Description: Text Data