[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 04/12] import: utils: Add spdx-string->license.
|
From: |
Ludovic Courtès |
|
Subject: |
Re: [PATCH 04/12] import: utils: Add spdx-string->license. |
|
Date: |
Mon, 26 Sep 2016 11:33:48 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
David Craven <address@hidden> skribis:
> * guix/import/utils.scm (spdx-string->license): New variable.
Eric wrote:
> SPDX seems to be a more general specification for licenses, but I
> still wonder whether its appropriate for (guix import utils), since
> its used only by the crate importer.
The generality is enough to put it here IMO, and npm appears to be using
it like David wrote.
> +(define (spdx-string->license str)
> + "Convert STR, a SPDX formatted license identifier, to a license object.
^^
Could you add the URL of the SPDX spec somewhere here?
> + Return #f if STR does not match any known identifiers."
^^^
Extra space.
Otherwise LGTM, thanks!
Ludo’.
- Re: [PATCH 07/12] import: crate: Add crate updater., (continued)
- [PATCH 09/12] gnu: Add rust-bootstrap-x86_64-1.12.0., David Craven, 2016/09/22
- [PATCH 12/12] gnu: Add rust helper functions., David Craven, 2016/09/22
- [PATCH 06/12] import: Add importer for rust crates., David Craven, 2016/09/22
- [PATCH 04/12] import: utils: Add spdx-string->license., David Craven, 2016/09/22
- [PATCH 08/12] build-system: Add cargo build system., David Craven, 2016/09/22
- [PATCH 10/12] gnu: Add rustc-bootstrap., David Craven, 2016/09/22
- Re: [PATCH 01/12] import: Move json-fetch to (guix import utils)., Eric Bavier, 2016/09/22