[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] profiles: manifest-lookup-package: Optionally match vers
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH 1/2] profiles: manifest-lookup-package: Optionally match version prefix. |
Date: |
Mon, 26 Sep 2016 12:41:02 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Ricardo Wurmus <address@hidden> skribis:
> * guix/profiles.scm (manifest-lookup-package): Optionally filter store
> item matches by version prefix.
[...]
> -(define (manifest-lookup-package manifest name)
> +(define* (manifest-lookup-package manifest name #:optional version)
> "Return as a monadic value the first package or store path referenced by
> -MANIFEST that named NAME, or #f if not found."
> +MANIFEST that is named NAME and optionally has the given VERSION prefix, or
> #f
> +if not found."
This should be phrased to mention that VERSION can be #f.
> + (let-values (((pkg-name pkg-version)
Rather ‘name*’ and ‘version*’, but no abbreviations.
> + (package-name->name+version
> + (store-path-package-name item))))
> + (and (equal? name pkg-name)
‘string=?’
OK with these changes, thanks!
Ludo’.