Re: gnu: Add emacs-rudel.

[ng0]

Hi,

thanks for reviewing.

Alex Vong <address@hidden> writes:

> Hello,
>
> ng0 <address@hidden> writes:
>
>> From b298b54bb732651daf7f7bb6a48e4749a4e391ed Mon Sep 17 00:00:00 2001
>> From: ng0 <address@hidden>
>> Date: Tue, 27 Sep 2016 16:24:29 +0000
>> Subject: [PATCH] gnu: Add emacs-rudel.
>>
>> * gnu/packages/emacs.scm (emacs-rudel): New variabel.
>> ---
>>  gnu/packages/emacs.scm | 29 ++++++++++++++++++++++++++++-
>>  1 file changed, 28 insertions(+), 1 deletion(-)
>>
>> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
>> index 57fe8a9..e0df7c9 100644
>> --- a/gnu/packages/emacs.scm
>> +++ b/gnu/packages/emacs.scm
>> @@ -12,7 +12,7 @@
>>  ;;; Copyright © 2016 David Thompson <address@hidden>
>>  ;;; Copyright © 2016 Matthew Jordan <address@hidden>
>>  ;;; Copyright © 2016 Roel Janssen <address@hidden>
>> -;;; Copyright © 2016 ng0 <address@hidden>
>> +;;; Copyright © 2016 ng0 <address@hidden>
>>  ;;; Copyright © 2016 Alex Griffin <address@hidden>
>>  ;;; Copyright © 2016 Nicolas Goaziou <address@hidden>
>>  ;;; Copyright © 2016 Alex Vong <address@hidden>
>> @@ -2222,6 +2222,33 @@ perspective only its buffers are available by 
>> default.")
>>      ;; the Expat license.
>>      (license license:gpl3+)))
>>  
>> +(define-public emacs-rudel
>> +  (package
>> +    (name "emacs-rudel")
>> +    (version "0.3.1")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (string-append "http://elpa.gnu.org/packages/rudel-";
>> +                           version ".tar"))
>> +       (sha256
>> +        (base32
>> +         "0glqa68g509p0s2vcc0i8kzlddnc9brd9jqhnm5rzxz4i050cvnz"))))
>> +    (build-system emacs-build-system)
>> +    (home-page "http://rudel.sourceforge.net/";)
> Should https be used?

Do sf.net have https certs? I don't believe so:

Oops! Unable to display this website
The site at https://rudel.sourceforge.net/ seems to be unavailable.

It may be temporarily inaccessible or moved to a new address. You may wish to 
verify that your internet connection is working correctly.

▼ Technical information
The precise error was: Could not connect: Connection refused

Reload

>> +    (synopsis "Collaborative editing framework")
>> +    (description
>> +     "Rudel is a collaborative editing environment for GNU Emacs.  Its 
>> purpose is to
>> +share buffers with other users in order to edit the contents of those 
>> buffers
>> +collaboratively.  Rudel supports multiple backends to enable communication 
>> with other
>> +collaborative editors using different protocols, though currently Obby (for 
>> use with
>> +the Gobby editor) is the only fully-functional one.
>> +Rudel mostly works in the background to change the behavior of the set of 
>> Emacs
>> +buffers for which it has been activated.  The user interface consists of a 
>> set of key
>> +bindings, a menu entry and some visual status indicators, which are added 
>> to the text,
>> +header line and/or mode line of buffers for which Rudel has been 
>> activated.")
>> +    (license license:gpl3+)))
>> +
> I think the lines are overly long here.

Less than 90 or even 89 characters.

address@hidden ~/src/guix/guix$ ./pre-inst-env guix lint emacs-rudel
;;; note: source file /home/ng0/src/guix/guix/gnu/packages/emacs.scm
;;;       newer than compiled /home/ng0/src/guix/guix/gnu/packages/emacs.go
gnu/packages/emacs.scm:2238:15: emacs-rudel-0.3.1: URI 
http://rudel.sourceforge.net/ unreachable: Connection refused
fetching CVE database for 2016.....

uri problem can be ignored, loads in web browsers.

>>  (define-public emacs-hydra
>>    (package
>>      (name "emacs-hydra")
>> -- 
>> 2.10.0
>
> Otherwise, the patch looks good and does build.

Yes. Functionality check is up to people who can use this, I was only
able to launch into rudel, no known server to connect to etc. I'd really
appreciate if someone would test it after this is commited.

> Some unrelated stuff to all: Right now, I only have free time on Tuesday
> and weekend, so I may not reply to email immediately.
>
> Cheers,
> Alex
>

-- 
              ng0