[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add scheme-bytestructures
From: |
Taylan Ulrich Bayırlı/Kammer |
Subject: |
Re: [PATCH] Add scheme-bytestructures |
Date: |
Tue, 11 Oct 2016 15:15:52 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
address@hidden (Ludovic Courtès) writes:
> Hi Amirouche,
>
> Some comments to complement Kei’s.
>
> Kei Kebreau <address@hidden> skribis:
>
>> Amirouche Boubekki <address@hidden> writes:
>>
>>> Warning: scheme-bytestructures works on various implementation of Scheme
>>> but this patch adds
>>> it only for guile-2.0.
>>>
>>> This is a pure scheme package there is no autotools that's why I use the
>>> trivial-build-system.
>>>
>>> This doesn't run the test suite, yet.
>>>
>>> From fb2eb7ffd88ec4fba09411195a54b59d67d9c137 Mon Sep 17 00:00:00 2001
>>> From: Amirouche <address@hidden>
>>> Date: Sun, 9 Oct 2016 12:31:20 +0200
>>> Subject: [PATCH] gnu: Add scheme-bytestructures
>>>
>>> * gnu/packages/guile.scm (scheme-bytestructures): New variable.
>>>
>>> diff --git a/gnu/packages/guile.scm b/gnu/packages/guile.scm
>>> index 0890f19..383990e 100644
>>> --- a/gnu/packages/guile.scm
>>> +++ b/gnu/packages/guile.scm
>>> @@ -1265,4 +1265,105 @@ is no support for parsing block and inline level
>>> HTML.")
>>> (define-public guile2.2-commonmark
>>> (package-for-guile-2.2 guile-commonmark))
>>>
>>> +(define-public scheme-bytestructures
>>> + (package
>>> + (name "scheme-bytestructures")
>
> I would suggest calling it “guile-scheme-bytestructures” (or
> “guile-bytestructures”?) to distinguish this package from the same one
> built for another implementation.
FWIW, second option sounds good to me (guile-bytestructures), speaking
as bytestructures author.
>>> + (license gpl3)))
>
> Probably ‘gpl3+’; could you check?
The intention is gpl3+ so if any file implies otherwise that's an error
on my end. I'm pretty sure I've used standard gpl3+ boilerplate
everywhere though.
Thanks all for doing this. :-)
Taylan
- [PATCH] Add scheme-bytestructures, Amirouche Boubekki, 2016/10/09
- Re: [PATCH] Add scheme-bytestructures, Kei Kebreau, 2016/10/10
- Re: [PATCH] Add scheme-bytestructures, Ludovic Courtès, 2016/10/10
- Re: [PATCH] Add scheme-bytestructures,
Taylan Ulrich Bayırlı/Kammer <=
- Re: [PATCH] Add scheme-bytestructures, Amirouche Boubekki, 2016/10/18
- Re: [PATCH] Add scheme-bytestructures, Ludovic Courtès, 2016/10/18
- Re: [PATCH] Add scheme-bytestructures, Amirouche Boubekki, 2016/10/19
- Re: [PATCH] Add scheme-bytestructures, Ludovic Courtès, 2016/10/20
- Re: [PATCH] Add scheme-bytestructures, Amirouche Boubekki, 2016/10/20
- Re: [PATCH] Add scheme-bytestructures, Ludovic Courtès, 2016/10/24