[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/5] gnu: python-zope-testing: Strip byte-code and garbage fr
From: |
Leo Famulari |
Subject: |
Re: [PATCH 3/5] gnu: python-zope-testing: Strip byte-code and garbage from source. |
Date: |
Wed, 12 Oct 2016 11:59:12 -0400 |
User-agent: |
Mutt/1.7.0 (2016-08-17) |
On Mon, Oct 10, 2016 at 03:10:01PM +0200, Hartmut Goebel wrote:
> * gnu/package/python.scm (python-zope-testing): Add snippet to strip
> byte-code and garbage from source.
Again, mention both python-zope-testing and python2-zope-testing, and
indicate that the changes are in [source].
Also, I think we should be more descriptive than "garbage".
> ---
> gnu/packages/python.scm | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
> index 345c6a7..a289093 100644
> --- a/gnu/packages/python.scm
> +++ b/gnu/packages/python.scm
> @@ -6647,7 +6647,13 @@ that have uses outside of the Zope framework.")
> "/zope.testing/zope.testing-" version ".tar.gz"))
> (sha256
> (base32
> - "1yvglxhzvhl45mndvn9gskx2ph30zz1bz7rrlyfs62fv2pvih90s"))))
> + "1yvglxhzvhl45mndvn9gskx2ph30zz1bz7rrlyfs62fv2pvih90s"))
> + (modules '((guix build utils)))
> + (snippet
> + '(begin
> + ;; Source contains .pyc files and some garbage
Please use a complete sentence here.
> + (for-each delete-file (find-files "." "(\\.pyc|~)$"))
> + #t))))
> (build-system python-build-system)
> (native-inputs
> `(("python-zope-exceptions" ,python-zope-exceptions)))
LGTM with the requested changes.
[PATCH 2/5] gnu: python-pytest-xdist: Remove python byte-code files from source., Hartmut Goebel, 2016/10/10
[PATCH 5/5] guix: python-build-system: Fix an outdated comment., Hartmut Goebel, 2016/10/10