[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/5] guix: python-build-system: Fix an outdated comment.
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH 5/5] guix: python-build-system: Fix an outdated comment. |
Date: |
Thu, 13 Oct 2016 22:06:58 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Hartmut Goebel <address@hidden> skribis:
> Am 12.10.2016 um 18:03 schrieb Leo Famulari:
>>> > (define %standard-phases
>>> > - ;; 'configure' and 'build' phases are not needed. Everything is done
>>> > during
>>> > - ;; 'install'.
>>> > + ;; 'configure' phase is not needed.
>> I have no real comment because I don't know the python-build-system well
>> enough. Is the sentence about 'install' no longer accurate?
>
> The python-build-system uses the build and the install phase, but not
> the configure phase. So the old comment was plain wrong. I assume once
> only the install phase was used[*] and the comment has had been correct :-)
>
> Which is possible and much like running "make install" without prior run
> to "make".
Indeed, I think this has been the case since commit
b191f88ee34576a6908b9b5e94cb7664e88c7e79.
Note however that Mark reverted this patch from master because it would
have caused a rebuild of all things Python. However feel free to apply
it to wip-python-build-system.
Thanks,
Ludo’.
- More duplicate package definitions, (continued)
[PATCH 2/5] gnu: python-pytest-xdist: Remove python byte-code files from source., Hartmut Goebel, 2016/10/10
[PATCH 5/5] guix: python-build-system: Fix an outdated comment., Hartmut Goebel, 2016/10/10
[PATCH 4/5] gnu: python.scm: Update some home-page urls and descriptions., Hartmut Goebel, 2016/10/10