[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] services: Add 'cuirass-service'.
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH 2/2] services: Add 'cuirass-service'. |
Date: |
Thu, 27 Oct 2016 15:36:02 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) |
Salut !
Mathieu Lirzin <address@hidden> skribis:
> * gnu/services/cuirass.scm: New file.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
> * doc/guix.texi (Continuous integration): New node.
[...]
> +++ b/doc/guix.texi
> @@ -7687,6 +7687,7 @@ declaration.
> * Mail Services:: IMAP, POP3, SMTP, and all that.
> * Web Services:: Web servers.
> * Network File System:: NFS related services.
> +* Continuous integration:: The cuirass service.
^ ^
Capitalize please. :-)
> address@hidden {Data Type} cuirass-configuration
> +Data type representing the configuration of Cuirass.
> +
> address@hidden @asis
> address@hidden @code{cache-directory} (default: "")
^^
Could you enclose it in @code? Same for the other default values.
> address@hidden %default-cuirass-configuration
So far we’ve used address@hidden {Scheme Variable} foo”, like Guile does. It
may be debatable, but I think we should be consistent.
I agree with Leo’s suggestion about the doc, but apart from that, it
looks all good. Nice work!
Thank you! I can’t wait to see it in action on the new machine. :-)
Ludo’.