[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: Add alsa-plugins.
From: |
Ricardo Wurmus |
Subject: |
Re: [PATCH] gnu: Add alsa-plugins. |
Date: |
Sat, 29 Oct 2016 23:35:51 +0200 |
User-agent: |
mu4e 0.9.16; emacs 26.0.50.1 |
ng0 <address@hidden> writes:
> * gnu/packages/linux.scm (alsa-plugins): New variable.
Thanks! This patch doesn’t apply to current master here. Does it need
rebasing?
> +(define-public alsa-plugins
> + (package
> + (name "alsa-plugins")
> + (version "1.1.1")
> + (source (origin
> + (method url-fetch)
> + (uri (string-append "ftp://ftp.alsa-project.org/pub/plugins/"
> + name "-" version ".tar.bz2"))
> + (sha256
> + (base32
> + "1w81z5jlwqhd1l2m7qrq69lc4k9dnrg1wn52jsl2hrf3hbhd394f"))))
> + (build-system gnu-build-system)
> + ;; TODO: Split libavcodec and speex if possible. It looks like they can
> not
> + ;; be split, there are references to both in files.
> + (outputs '("out" "pulseaudio"))
> + (arguments
> + `(#:phases
> + (modify-phases %standard-phases
> + (add-after 'install 'split
> + (lambda* (#:key inputs outputs #:allow-other-keys)
> + ;; Split the binaries to the various outputs.
“Distribute” is probably better than “Split” here.
> + (rename-file (string-append out "/share/alsa/alsa.conf.d/"
> + "50-pulseaudio.conf")
> + (string-append pua "/share/alsa/alsa.conf.d/"
> + "50-pulseaudio.conf"))
> + (rename-file (string-append out "/share/alsa/alsa.conf.d/"
> +
> "99-pulseaudio-default.conf.example")
> + (string-append pua "/share/alsa/alsa.conf.d/"
> +
> "99-pulseaudio-default.conf.example"))
> + (rename-file (string-append out "/lib/alsa-lib/"
> + "libasound_module_conf_pulse.la")
> + (string-append pua "/lib/alsa-lib/"
> + "libasound_module_conf_pulse.la"))
> + (rename-file (string-append out "/lib/alsa-lib/"
> + "libasound_module_conf_pulse.so")
> + (string-append pua "/lib/alsa-lib/"
> + "libasound_module_conf_pulse.so"))
> + (rename-file (string-append out "/lib/alsa-lib/"
> + "libasound_module_ctl_pulse.la")
> + (string-append pua "/lib/alsa-lib/"
> + "libasound_module_ctl_pulse.la"))
> + (rename-file (string-append out "/lib/alsa-lib/"
> + "libasound_module_ctl_pulse.so")
> + (string-append pua "/lib/alsa-lib/"
> + "libasound_module_ctl_pulse.so"))
> + (rename-file (string-append out "/lib/alsa-lib/"
> + "libasound_module_pcm_pulse.la")
> + (string-append pua "/lib/alsa-lib/"
> + "libasound_module_pcm_pulse.la"))
> + (rename-file (string-append out "/lib/alsa-lib/"
> + "libasound_module_pcm_pulse.so")
> + (string-append pua "/lib/alsa-lib/"
> + "libasound_module_pcm_pulse.so"))
> + (delete-file-recursively (string-append out
> "/share"))))))))
That’s a bit crude. Can’t you use “find-files” with a pattern to find
all files containing “pulse” and then use “for-each” to move all files?
One more thing: could you check with “guix gc --references” to confirm
that the separate outputs do not contain “bad” references? The “out”
output should not contain a reference to “pulseaudio”, otherwise
distributing binaries to outputs is pointless.
> + (inputs
> + `(("alsa-lib" ,alsa-lib)
> + ("speex" ,speex) ; libspeexdsp resampling plugin
> + ("libsamplerate" ,libsamplerate) ; libsamplerate resampling plugin
> + ("ffmpeg" ,ffmpeg) ; libavcodec resampling plugin, a52 plugin
> + ("pulseaudio" ,pulseaudio))) ; PulseAudio plugin
> + (native-inputs
> + `(("pkg-config" ,pkg-config)))
> + (home-page "http://www.alsa-project.org/")
> + (synopsis "Utilities for the Advanced Linux Sound Architecture (ALSA)")
> + (description
> + "The Advanced Linux Sound Architecture (ALSA) provides audio and
> +MIDI functionality to the Linux-based operating system. This package
> provides
> +additional plugins.")
“additional plugins” is a bit short. What do they do (in general), why
would I want them?
> + (license (list license:gpl2+
> + ;; `rate/rate_samplerate.c': LGPL v2.1 or later.
> + license:lgpl2.1+))))
> +
Could you please send an updated patch?
~~ Ricardo