Re: [PATCH] gnu: Add libjxr.

[Ludovic Courtès]

Kei Kebreau <address@hidden> skribis:

> From 316a4f7a676bf6b8cc7a8f8795b74fa0ebab3e36 Mon Sep 17 00:00:00 2001
> From: Kei Kebreau <address@hidden>
> Date: Sun, 30 Oct 2016 11:05:30 -0400
> Subject: [PATCH] gnu: Add libjxr.
>
> * gnu/packages/images.scm (libjxr): New variable.
> * gnu/packages/patches/libjxr-fix-function-signature.patch: New file.
> * gnu/packages/patches/libjxr-fix-typos.patch: New file.
> * gnu/local.mk (dist_patch_DATA): Register patches.

[...]

> +(define-public libjxr
> +  (package
> +    (name "libjxr")
> +    (version "1.1")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append 
> "mirror://debian/pool/main/j/jxrlib/jxrlib_"
> +                                  version ".orig.tar.gz"))

Please add a comment saying why we’re using the Debian-provided source.

> +                   (replace 'install
> +                     (lambda* (#:key outputs #:allow-other-keys)

… and a comment saying why we roll our own ‘install’ phase.

OK with these changes, thanks!

Ludo’.