Re: [PATCH] gnu: Add Handbrake.

[Eric Bavier]

On Mon, 31 Oct 2016 10:30:40 +0100
Ricardo Wurmus <address@hidden> wrote:

> Eric Bavier <address@hidden> writes:
> 
> > * gnu/packages/video.scm (handbrake): New variable.
> > * gnu/packages/patches/handbrake-pkg-config-path.patch: New patch.
> > * gnu/local.mk (dist_patch_DATA): Add it.  
> 
> Yay, thanks for the patch!

Thanks for the feedback!  I've incorporated your and Efraim's
suggestions in the attached patch.  

The resulting Handbrake mostly works, but the default transcoding
presets and gui icons are missing.  I've done as much as I can to debug
this, but I can't put any more time into it.  I could commit this
as-is and fix it later, or someone else could pick it up.

Handbrake bundles quite a few libraries, often with non-trivial patches.
This package modifies the build a bit to use system libraries
(something the handbrake devs emphatically do *not* support).  I
wouldn't feel comfortable using the bundled libraries until there was a
more comprehensive assesment of the library versions and the patches
made.

`~Eric

0001-gnu-Add-Handbrake.patch
Description: Text Data