|
From: | Clément Lassieur |
Subject: | Re: [PATCH] gnu: Add Prosody service. |
Date: | Sun, 08 Jan 2017 20:06:19 +0100 |
User-agent: | mu4e 0.9.18; emacs 25.1.1 |
> I would suggest moving the gnu/packages change to a separate patch, but > apart from that I don’t have anything to add to Hartmut’s comment. > > Could you send updated patches? Here they are. > I suppose you confirmed with ‘guix system vm’ or similar that it works > as intended. Could you consider writing a system test for Prosody? The > (gnu tests mail) and (gnu tests ssh) modules provide relatively simple > examples to start from. It works on my GuixSD server. I'll start to write a system test. Thank you all for the review!
[Prev in Thread] | Current Thread | [Next in Thread] |