[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/1] gnu: Add Guile-ICS.
From: |
Alex Sassmannshausen |
Subject: |
Re: [PATCH 1/1] gnu: Add Guile-ICS. |
Date: |
Mon, 09 Jan 2017 11:37:07 +0100 |
User-agent: |
mu4e 0.9.16; emacs 25.1.1 |
Hi Ludo,
Ludovic Courtès writes:
> Howdy!
>
> Alex Sassmannshausen <address@hidden> skribis:
>
> [...]
>
>> + (version "0.1.1-rc1")
>
> Apparently 0.1.1 is already out!
>
> However the tarball contains .go files, which should be removed.
>
> But it might be best to just download from github.com and add a
> bootstrap phase, like I did for Guile-SSH, because memory-heap.org is
> slow and sometimes disappeared in the past.
Indeed — I'm now building 0.1.1 from a git checkout from github.com.
>> + (arguments
>> + '(#:configure-flags
>> + (list (string-append
>> + "--with-guile-site-dir=" %output "/share/guile/site/2.0"))))
>
> This can be omitted (in fact, adding it would lead compilations with
> Guile 2.2 to install modules in the wrong place.)
Thanks, removed.
>> + (license gpl3)))
>
> gpl3+
Done.
> OK with these changes, thanks!
I've updated the package, tested in
`guix environment --pure --container` and `guix lint`, and then I pushed
it to master.
Thanks for the review!
Alex