[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 00/10] ocaml patches
From: |
Julien Lepiller |
Subject: |
Re: [PATCH 00/10] ocaml patches |
Date: |
Thu, 19 Jan 2017 09:56:56 +0100 |
On Wed, 18 Jan 2017 23:27:06 +0100
Marius Bakke <address@hidden> wrote:
> Julien Lepiller <address@hidden> writes:
>
> > Here are the next 10 ocaml-related patches I would like to push.
> > What do you think?
>
> I don't know anything about ocaml, but the patches reads fine to me.
>
> One thing that strikes me is the usage of native-inputs; I assume it's
> because the packages are not referenced, but bear in mind that they
> are built for the architecture of the build machine, and not for the
> target system.
I use native-inputs because the build system needs binaries (not
libraries) from these packages.
>
> E.g. `guix build --system=i686-linux ocamlify` will add 64-bit
> native-inputs even if the final product is supposed to be 32-bit. Not
> sure if that will cause problems or not.
Just to be sure, I'll cross-compile them. I'll send updated patches
soon.
>
> > I'm pretty sure number 9 and 10 can be improved, any idea?
>
> Not from me, I'd say it looks fine :-)
Thanks for your review :)
- [PATCH 06/10] gnu: Add ocaml-expect., (continued)
- [PATCH 06/10] gnu: Add ocaml-expect., Julien Lepiller, 2017/01/18
- [PATCH 05/10] gnu: Add ocaml-pcre., Julien Lepiller, 2017/01/18
- [PATCH 08/10] gnu: Add ocaml-oasis., Julien Lepiller, 2017/01/18
- [PATCH 07/10] gnu: Add ocaml-fileutils., Julien Lepiller, 2017/01/18
- [PATCH 10/10] gnu: Add ocaml-bin-prot., Julien Lepiller, 2017/01/18
- [PATCH 09/10] gnu: Add ocaml-js-build-tools., Julien Lepiller, 2017/01/18
- Re: [PATCH 00/10] ocaml patches, Marius Bakke, 2017/01/18
- Re: [PATCH 00/10] ocaml patches,
Julien Lepiller <=
- [PATCH 00/10] ocaml patches, Julien Lepiller, 2017/01/31
- [PATCH 02/10] gnu: Add ocaml-ppx-core., Julien Lepiller, 2017/01/31
- [PATCH 01/10] gnu: Add ocaml-fieldslib., Julien Lepiller, 2017/01/31
- [PATCH 03/10] gnu: Add ocaml-ppx-optcomp., Julien Lepiller, 2017/01/31
- [PATCH 04/10] gnu: Add ocaml-ppx-driver., Julien Lepiller, 2017/01/31
- [PATCH 05/10] gnu: Add ocaml-cppo., Julien Lepiller, 2017/01/31
- [PATCH 06/10] gnu: Add ocaml-ppx-deriving., Julien Lepiller, 2017/01/31
- [PATCH 07/10] gnu: Add ocaml-ppx-type-conv., Julien Lepiller, 2017/01/31
- [PATCH 08/10] gnu: Add ocaml-ppx-inline-test., Julien Lepiller, 2017/01/31
- [PATCH 09/10] gnu: Add ocaml-ppx-bench., Julien Lepiller, 2017/01/31