Re: [PATCH 1/2] gnu: Add mbedtls.

[ng0]

Leo Famulari <address@hidden> writes:

> On Wed, Jan 25, 2017 at 12:25:17PM +0000, address@hidden wrote:
>> * gnu/packages/tls.scm (mbedtls): New variable.
>
>> +       ;; FIXME: Tarball on tls.mbed.org can no be fetched by our 
>> downloader.
>
> Please add a comment explaining what goes wrong.
>
>> +    (native-inputs
>> +     `(("perl" ,perl) ; Tests
>> +       ("doxygen" ,doxygen)
>> +       ("graphviz" ,graphviz)))
>> +    (inputs
>> +     `(("zlib" ,zlib)
>> +       ("openssl" ,openssl)))
>
> The only dependency it needs to build is Perl.
>
> The rest can be missing and mbedtls will still pass its test suite.
>
> Doxygen seems unused; no documentation is installed when its available.
>
> If they are available, zlib and openssl are not referred to by the output
> (checked with `guix gc --references`).

Good catch, seems like some things have indeed changed since I
wrote the Gentoo ebuild. Check yourself I guess...
Thanks!

These are small changes, I see to send them in today. Thanks for
the review.
-- 
♥Ⓐ  ng0 -- https://www.inventati.org/patternsinthechaos/