Re: [PATCH] gnu: Add reducelcs.

[Kei Kebreau]

address@hidden writes:

> From: ng0 <address@hidden>
>
> * gnu/packages/lcs.scm: New file.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add lcs.scm.

What do you think necessitates the creation of a new file for this
package? It seems to me it would fit in maths.scm, but I may just be ignorant.

> ---
>  gnu/local.mk         |  1 +
>  gnu/packages/lcs.scm | 67 
> ++++++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 68 insertions(+)
>  create mode 100644 gnu/packages/lcs.scm
>
> diff --git a/gnu/local.mk b/gnu/local.mk
> index 217d31712..0e915cb32 100644
> --- a/gnu/local.mk
> +++ b/gnu/local.mk
> @@ -203,6 +203,7 @@ GNU_SYSTEM_MODULES =                              \
>    %D%/packages/key-mon.scm                   \
>    %D%/packages/kodi.scm                              \
>    %D%/packages/language.scm                  \
> +  %D%/packages/lcs.scm                          \
>    %D%/packages/ldc.scm                               \
>    %D%/packages/lego.scm                              \
>    %D%/packages/less.scm                              \
> diff --git a/gnu/packages/lcs.scm b/gnu/packages/lcs.scm
> new file mode 100644
> index 000000000..6b00098ae
> --- /dev/null
> +++ b/gnu/packages/lcs.scm
> @@ -0,0 +1,67 @@
> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright © 2017 ng0 <address@hidden>
> +;;;
> +;;; This file is part of GNU Guix.
> +;;;
> +;;; GNU Guix is free software; you can redistribute it and/or modify it
> +;;; under the terms of the GNU General Public License as published by
> +;;; the Free Software Foundation; either version 3 of the License, or (at
> +;;; your option) any later version.
> +;;;
> +;;; GNU Guix is distributed in the hope that it will be useful, but
> +;;; WITHOUT ANY WARRANTY; without even the implied warranty of
> +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +;;; GNU General Public License for more details.
> +;;;
> +;;; You should have received a copy of the GNU General Public License
> +;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
> +
> +(define-module (gnu packages lcs)
> +  #:use-module ((guix licenses) #:prefix license:)
> +  #:use-module (guix packages)
> +  #:use-module (gnu packages)
> +  #:use-module (gnu packages maths)
> +  #:use-module (guix git-download)
> +  #:use-module (guix build-system gnu))
> +
> +(define-public reducelcs
> +  ;; This is the last commit which is available upstream, no
> +  ;; tarball release happened since 2010.
> +  (let ((commit "474f88deb968061abe8cf11c959e02319b8ae5c0")
> +        (revision "1"))
> +    (package
> +      (name "reducelcs")
> +      (version (string-append "0.0.0-" revision "." (string-take commit 7)))
> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url "https://github.com/gdv/Reduce-Expand-for-LCS";)
> +               (commit commit)))
> +         (file-name (string-append name "-" version "-checkout"))
> +         (sha256
> +          (base32
> +           "1rllzcfwc042c336mhq262a8ha90x6afq30kvk60r7i4761j4yjm"))))
> +      (build-system gnu-build-system)
> +      (inputs
> +       `(("openlibm" ,openlibm)))
> +      (arguments
> +       `(#:tests? #f ; no tests
> +         #:phases
> +         (modify-phases %standard-phases
> +           (delete 'configure) ; no configure script
> +           (replace 'install ; no install phase either
> +             (lambda* (#:key outputs #:allow-other-keys)
> +               (let* ((out (assoc-ref outputs "out"))
> +                      (bin (string-append out "/bin")))
> +                 (install-file "Approximation" bin)
> +                 (install-file "CollectResults" bin)
> +                 (install-file "GenerateInstances" bin)
> +                 #t))))))
> +      (synopsis "Approximate Longest Commons Subsequence computation tool")
> +      (description
> +       "@code{reduceLCS} is an implementation of the Reduce-Expand
> +algorithm for LCS.  It is a fast program to compute the approximate
> +Longest Commons Subsequence of a set of strings.")
> +      (home-page "http://gianluca.dellavedova.org/software/";)

I think you can link to the Github repo here. Lots of other packages do that.

> +      (license license:gpl2))))

The most recent version of this software is covered by the GPLv3 (and
later? IANAL).

signature.asc
Description: PGP signature