guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/3] gnu: Add zpaq.


From: Ludovic Courtès
Subject: Re: [PATCH 3/3] gnu: Add zpaq.
Date: Mon, 30 Jan 2017 23:54:46 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)

Tobias Geerinckx-Rice <address@hidden> skribis:

> * gnu/packages/compression.scm (zpaq): New variable.

[...]

> +        (string-append "CXXFLAGS=-O3 -mtune=generic -DNDEBUG"
> +                       ,(match (or (%current-target-system)
> +                                   (%current-system))
> +                               ("x86_64-linux"  " -march=nocona")
> +                               ("i686-linux"    " -march=i686")
> +                               (_               "")))

Maybe add a note as to why these are needed.

> +    (home-page "http://mattmahoney.net/dc/zpaq.html";)
> +    (synopsis "Incremental journaling archiver")
> +    (description "ZPAQ is a command-line archiver that backs up faster and
> +compresses better than most other popular archivers in realistic situations
> +with many duplicate and already compressed files.  It backs up only those 
> files

I’d tone down the first sentence.  :-)

Otherwise LGTM, thank you!

Ludo’.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]