Re: [PATCH] gnu: new re2c package, version 0.16

[Sergei Trofimovich]

On Sun, 5 Feb 2017 00:47:30 +0000
ng0 <address@hidden> wrote:

> On 17-02-04 17:43:23, Sergei Trofimovich wrote:
> > Tested on x86_64-linux and i686-linux.
> > 
> > * gnu/local.mk: add re2c.scm to dist
> > * gnu/packages/re2c.scm: new file  
> 
> Cool! I had the same package somewhere, thanks for publishing yours :)
> I think there's already a module this could go into. If there isn't (I
> will check tomorrow), what about a more generic name which could hold a
> class of applications? Just an idea.

I mimicked flex which resides in standalone flex.scm.

> I haven't run the code, these are just my initial remarks. Overall it
> looks good, so the only criticism is really in the (description).

> I think the beginning should be "Re2c (...)" or "@code{re2c} (...)"
> 
> > +full-featured table-based lexers).  Flexible API allows generated code to
> > +be wired into virtually any environment.  Instead of exposing traditional
> > +yylex() style API, re2c exposes its internals.  Be sure to take a look at  

Fixed in v2 patch.

> I'm not sure, but I think the "yylex()" will have to be written as
> @code{yylex()} or something similar.
> 
> > +examples, they cover a lot of real-world cases and shed some light on dark
> > +corners of re2c API.")  

Fixed in v2 patch.

> I think "corners of the re2c API." would be correct?

Author's spelling:
    https://raw.githubusercontent.com/skvadrik/re2c/gh-pages-gen/src/index.rst

I'm not sure which is right:
    
http://english.stackexchange.com/questions/10020/definite-article-before-schools-colleges-and-universities

-- 

  Sergei

pgpMZPYjocDiG.pgp
Description: Цифровая подпись OpenPGP