guix-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] substitute: Close the download port after substitution finis


From: 宋文武
Subject: Re: [PATCH] substitute: Close the download port after substitution finished.
Date: Mon, 18 Sep 2017 19:11:52 +0800
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux)

address@hidden (Ludovic Courtès) writes:

> Hi 宋文武,
>
> 宋文武 <address@hidden> skribis:
>
>> * guix/scripts/substitute.scm (progress-substitution): Call 'close-port'
>> after 'restore-file'.
>
> Good catch, please push!
>
> How did you notice?

I meet it when test my progress reporter patch at
<https://lists.gnu.org/archive/html/guix-devel/2017-09/msg00190.html>,
which will write the last report to console after close
'progress-report-port'.


Pushed, thanks for the review!



reply via email to

[Prev in Thread] Current Thread [Next in Thread]