[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] gnu: Add guile-dsv.
From: |
Alex Sassmannshausen |
Subject: |
Re: [PATCH] gnu: Add guile-dsv. |
Date: |
Sat, 25 Nov 2017 00:28:47 +0100 |
User-agent: |
mu4e 0.9.18; emacs 25.3.1 |
Hi Ludo,
Thanks for the review, I've pushed it with the changes you proposed.
Cheers,
Alex
Ludovic Courtès writes:
> Hi Alex,
>
> Alex Sassmannshausen <address@hidden> skribis:
>
>> * gnu/packages/guile.scm (guile-dsv): New variable.
>
> [...]
>
>> + (inputs `(("guile" ,guile-2.2)))
>> + (propagated-inputs `(("guile-lib" ,guile2.2-lib)))
>
> Should be ‘guile-lib’ instead of ‘guile2.2-lib’ (the latter is a
> deprecated alias.)
>
>> + (synopsis "DSV module for Guile")
>> + (description
>> + "Guile-DSV is a GNU Guile module for working with the
>> +delimiter-separated values (DSV) data format.
>> +
>> +Guile-DSV supports the Unix-style DSV format and RFC 4180 format.
>> +")
>
> I think you can remove the extra newlines.
>
>> + (license license:gpl3)))
>
> ‘gpl3+’ I guess?
>
> OK with these changes, thank you!
>
> Ludo’.