Hi,
thank you for your contribution!
1 . I put the package under fontutils.scm but maybe there's a better
place for a font viewer?
This seems fine to me.
2. I found there is a glib-or-gtk-build-system, I hesitated to use as
Im̀
not sure what its purpose. Can someone clarify its use?
The glib-or-gtk-build-system is an extension of the gnu-build-system
that is useful for GNOME packages and other packages that require a
little more setup after installation. Here’s what the comments in
“guix/build-system/glib-or-gtk.scm” say:
;; This build system is an extension of the 'gnu-build-system'. It
;; accomodates the needs of applications making use of glib or gtk+
(with "or"
;; to be interpreted in the mathematical sense). This is achieved by
adding
;; two phases run after the 'install' phase:
;;
;; 'glib-or-gtk-wrap' phase:
;;
;; a) This phase looks for GSettings schemas, GIO modules and theming
data.
;; If any of these is found in any input package, then all programs in
;; "out/bin" are wrapped in scripts defining the nedessary environment
;; variables.
;;
;; b) Looks for the existence of "libdir/gtk-3.0" directories in all
input
;; packages. If any is found, then the environment variable "GTK_PATH"
is
;; suitably set and added to the wrappers. The variable "GTK_PATH" has
been
;; preferred over "GTK_EXE_PREFIX" because the latter can only point to
a
;; single directory, while we may need to point to several ones.
;;
;; 'glib-or-gtk-compile-schemas' phase:
;;
;; Looks for the presence of "out/share/glib-2.0/schemas". If that
directory
;; exists and does not include a file named "gschemas.compiled", then
;; "glib-compile-schemas" is run in that directory.
3. I tried to get a clean patch but it needed some manual work. What
your workflow to produce patches? (I use emacs)
Usually you would make a local git commit and then run
git format-patch -1
to generate a patch file from that commit. You could also directly
send
it to the mailing list with “git send-email”.
What follows are some comments about the patch. I’m trying to be extra
thorough; please don’t let this discourage you. Some of my comments
will just be matters of opinion :)