Re: 01/01: gnu: Add hyperledger-fabric.

[Pierre Neidhardt]

> >     gnu: Add hyperledger-fabric.
> >     
> >     * gnu/local.mk (hyperledger): New variable.
> 
> Really?  :-)

Oops! :(

> I don’t know how much of a difference it makes in this case but it might
> be worth considering passing “-j” (number->string (parallel-job-count)).

Absolutely, will do.

> Then again, this “linux-amd64” thing looks worrying: can you confirm the
> checkout doesn’t contain pre-built binaries?

It does not.  The supported archs are set in the Makefile:
https://github.com/hyperledger/fabric/blob/release-1.4/Makefile#L340

> Please turn the description into a sentence, and ideally something less
> marketing-ish.  :-)

Forgot to double check that, sorry!

Thanks for the review!

-- 
Pierre Neidhardt
https://ambrevar.xyz/

signature.asc
Description: PGP signature