Re: [PATCH 1/2] Support publishing build events

[Christopher Baines]

Ludovic Courtès <address@hidden> writes:

> Hi Chris,
>
> Christopher Baines <address@hidden> skribis:
>
>> ---
>>  Makefile.am                 |   8 +-
>>  bin/cuirass-send-events.in  |  90 +++++++++++++++++++++++
>>  src/cuirass/base.scm        |   9 ++-
>>  src/cuirass/database.scm    | 142 +++++++++++++++++++++++++++++++++---
>>  src/cuirass/http.scm        |  24 ++++++
>>  src/cuirass/send-events.scm |  69 ++++++++++++++++++
>>  src/schema.sql              |  12 +++
>>  src/sql/upgrade-5.sql       |  15 ++++
>>  8 files changed, 356 insertions(+), 13 deletions(-)
>>  create mode 100644 bin/cuirass-send-events.in
>>  create mode 100644 src/cuirass/send-events.scm
>>  create mode 100644 src/sql/upgrade-5.sql
>
> Sorry for the delay.  It LGTM, thank you!
>
> Please add a commit log :-), and let us know when you’d like to test
> with the instance on berlin or that on bayfront.

Great :)

I have access to bayfront already, so I think that's the place to try
this out initially.

> IIUC, the ‘send-events’ program is provided as a debugging aid, right?
> I mean it’s not used anywhere in the code.

Well, it would be potentially better to send the events from the same
Cuirass process that manages the builds, as then the events could be
sent out immediately.

However, I don't really know how fibers work, so I went with a separate
process to make it easier to manually test, and to reduce any risk of
interfering with other Cuirass functions.

> If you can think of ways to tests parts of this, that’d also be great,
> but it shouldn’t block it.

Ok. I'll hopefully have some time in the next week or two to take
another look. I'll add change logs to the commits, do some more manual
testing, and have a look at writing some automated tests.

Thanks,

Chris

signature.asc
Description: PGP signature