[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: 05/36: vm: Make the device node procedure a parameter.
From: |
Ludovic Courtès |
Subject: |
Re: 05/36: vm: Make the device node procedure a parameter. |
Date: |
Sun, 03 May 2020 22:34:38 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) |
Hi!
Jan Nieuwenhuizen <address@hidden> skribis:
> We may even want to move this (and "friends") into the qemu-image
> declaration itself; in a much later patch on wip-hurd-vm I have
>
> (define* qemu-image #:key
> [...]
> - (file-system-type "ext4")
> - (file-system-options '())
> - (device-nodes 'linux)
> + (file-system-type (if (hurd-target?) "ext2" "ext4"))
> + (file-system-options
> + (if (hurd-target?) '("-o" "hurd") '()))
> + (device-nodes (if (hurd-target?) 'hurd 'linux))
>
> Having linux-specific defaults in a generic function is kind of awkward;
> we would need to change all callers, or ...
Ah yes, we should do something like that.
Ludo’.