[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 7/9] build: qemu-command: Add support for powerpc.
From: |
Efraim Flashner |
Subject: |
Re: [PATCH 7/9] build: qemu-command: Add support for powerpc. |
Date: |
Tue, 6 Apr 2021 22:17:28 +0300 |
On Tue, Apr 06, 2021 at 07:02:47PM +0200, Vincent Legoll wrote:
> Hello,
>
> On Tue, Apr 6, 2021 at 2:44 PM Efraim Flashner <efraim@flashner.co.il> wrote:
> > + ((string-match "powerpc" cpu) "ppc")
>
> Won't there be some "powerpc64le" conflict here ?
>
I thought not, but it appears it would match all of powerpc*
(ins)scheme@(guile-user)> (use-modules (ice-9 regex))
(ins)scheme@(guile-user)> (string-match "powerpc" "powerpc")
$1 = #("powerpc" (0 . 7))
(ins)scheme@(guile-user)> (string-match "powerpc" "powerpc64le")
$2 = #("powerpc64le" (0 . 7))
(ins)scheme@(guile-user)> (string-match "powerpc" "armhf")
$3 = #f
If it were string=? then it would be fine, but that would break the
^i[3456]86$ regex. It looks like I would need to add a powerpc64 case
above the powerpc case. Looking at the output of qemu adding
((string-match "powerpc64" cpu) "ppc64") would be the right answer.
--
Efraim Flashner <efraim@flashner.co.il> אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
signature.asc
Description: PGP signature
- Re: bug#47615: [PATCH 0/9] Add 32-bit powerpc support, (continued)
[PATCH 4/9] gnu: mesa: Add support for powerpc-linux., Efraim Flashner, 2021/04/06
[PATCH 5/9] gnu: Add mac-fdisk., Efraim Flashner, 2021/04/06
[PATCH 6/9] gnu: american-fuzzy-lop: Add support for powerpc-linux., Efraim Flashner, 2021/04/06
[PATCH 7/9] build: qemu-command: Add support for powerpc., Efraim Flashner, 2021/04/06
[PATCH 8/9] gnu: mercurial: Skip tests on powerpc-linux., Efraim Flashner, 2021/04/06
[PATCH 9/9] gnu: nss: Skip tests on powerpc-linux., Efraim Flashner, 2021/04/06
Re: [PATCH 0/9] Add 32-bit powerpc support, Vincent Legoll, 2021/04/07
Re: [PATCH 0/9] Add 32-bit powerpc support, Ludovic Courtès, 2021/04/17