[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Outreachy - Guix Data Service: implementing basic json output for de
From: |
Luciana Lima Brito |
Subject: |
Re: Outreachy - Guix Data Service: implementing basic json output for derivation comparison page |
Date: |
Sun, 18 Apr 2021 19:12:30 +0000 |
Hi,
On Sun, 18 Apr 2021 17:34:13 +0100
Christopher Baines <mail@cbaines.net> wrote:
> I think it might be good to do something, just to narrow the scope.
> The outputs binding is valid for the whole let*, and all the code in
> it, but is only used on three lines, in one single place. Maybe there
> could be a let there that just defines outputs (maybe named
> output-groups so you can use the outputs binding for the overall
> thing).
I did it.
> That's a good question, I'd look at the database schema, assuming the
> type of the field is a boolean, the question is whether the field is
> nullable?
I looked on the database schema, and the "recursive" field is not
nullable, and it is a boolean, so the test I'm doing is working for
this.
> Hmm, I'm not sure why that is on the HTML page, but I'd generally try
> and keep most bits in the JSON, since it's not as helpful to omit bits
> if they're not that important.
I added the "common" field for inputs.
>
> One other thing I noticed is that the alist for the args is being
> picked apart then reconstructed. Like for the inputs, outputs and
> sources, I'd map over the arguments alist and transform it to the way
> you want it to be.
This part was a bit more complicated for me to understand. You mean I
should build a function similar to outputs, inputs and sources to map
the arguments, wouldn't it be a lot just to show a vector?
--
Best Regards,
Luciana Lima Brito
MSc. in Computer Science
0001-Implement-basic-json-output-for-the-derivation-compa.patch
Description: Text Data
- Re: Outreachy - Guix Data Service: implementing basic json output for derivation comparison page, (continued)
- Re: Outreachy - Guix Data Service: implementing basic json output for derivation comparison page, Christopher Baines, 2021/04/16
- Re: Outreachy - Guix Data Service: implementing basic json output for derivation comparison page, Luciana Lima Brito, 2021/04/16
- Re: Outreachy - Guix Data Service: implementing basic json output for derivation comparison page, Christopher Baines, 2021/04/17
- Re: Outreachy - Guix Data Service: implementing basic json output for derivation comparison page, Luciana Lima Brito, 2021/04/17
- Re: Outreachy - Guix Data Service: implementing basic json output for derivation comparison page, Christopher Baines, 2021/04/17
- Re: Outreachy - Guix Data Service: implementing basic json output for derivation comparison page, Luciana Lima Brito, 2021/04/17
- Re: Outreachy - Guix Data Service: implementing basic json output for derivation comparison page, Christopher Baines, 2021/04/17
- Re: Outreachy - Guix Data Service: implementing basic json output for derivation comparison page, Luciana Lima Brito, 2021/04/18
- Re: Outreachy - Guix Data Service: implementing basic json output for derivation comparison page, Luciana Lima Brito, 2021/04/18
- Re: Outreachy - Guix Data Service: implementing basic json output for derivation comparison page, Christopher Baines, 2021/04/18
- Re: Outreachy - Guix Data Service: implementing basic json output for derivation comparison page,
Luciana Lima Brito <=
- Re: Outreachy - Guix Data Service: implementing basic json output for derivation comparison page, Christopher Baines, 2021/04/19
- Re: Outreachy - Guix Data Service: implementing basic json output for derivation comparison page, Luciana Lima Brito, 2021/04/19
- Re: Outreachy - Guix Data Service: implementing basic json output for derivation comparison page, Christopher Baines, 2021/04/19
- Re: Outreachy - Guix Data Service: implementing basic json output for derivation comparison page, Luciana Lima Brito, 2021/04/19